-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
api-fetch: Align exported type names with DefinitelyTyped types #30570
Conversation
Size Change: 0 B Total Size: 1.42 MB 鈩癸笍 View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me. Do you think anyone would be consuming these types yet?
So the way TypeScript resolves types is that if it finds a |
How soon? We started the release cycle for the Gutenberg plugin, so we could cherry-pick it to |
The current release is unusable if TypeScript is involved in someone's build pipeline, so technically broken. I'm not sure how many people this effects though. One more week probably won't hurt that much more. |
* api-fetch: Align exported type names with DefinitelyTyped types * Update changelog
I cherry-picked f84d26e to the release branch for Gutenberg 10.4 and updated the milestone. If we get some reports that something gets completely broken we can always do a hotfix that is always some additional work. |
Description
It seems that by not aligning the type names exported by the api-fetch package with the types exported on DefinitelyTyped, I broke something in a bad way: Automattic/wp-calypso#51723 (comment)
This PR aligns the types with the names exported by the DefinitelyTyped package. This is an important thing to note for the future, that we need to make sure that these align or we'll cause regressions 馃槥
How has this been tested?
I'm not sure how to test that this fixes the problem. Any suggestions are welcome.
Types of changes
Bug fix. We should publish this as soon as possible.
Checklist:
*.native.js
files for terms that need renaming or removal).