api-fetch: Align exported type names with DefinitelyTyped types #30570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Bug
1 task
|
Size Change: 0 B Total Size: 1.42 MB 鈩癸笍 View Unchanged
|
noahtallen
approved these changes
Apr 7, 2021
|
So the way TypeScript resolves types is that if it finds a |
How soon? We started the release cycle for the Gutenberg plugin, so we could cherry-pick it to |
The current release is unusable if TypeScript is involved in someone's build pipeline, so technically broken. I'm not sure how many people this effects though. One more week probably won't hurt that much more. |
gziolo
pushed a commit
that referenced
this pull request
Apr 9, 2021
* api-fetch: Align exported type names with DefinitelyTyped types * Update changelog
|
I cherry-picked f84d26e to the release branch for Gutenberg 10.4 and updated the milestone. If we get some reports that something gets completely broken we can always do a hotfix that is always some additional work. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that by not aligning the type names exported by the api-fetch package with the types exported on DefinitelyTyped, I broke something in a bad way: Automattic/wp-calypso#51723 (comment)
This PR aligns the types with the names exported by the DefinitelyTyped package. This is an important thing to note for the future, that we need to make sure that these align or we'll cause regressions 馃槥
How has this been tested?
I'm not sure how to test that this fixes the problem. Any suggestions are welcome.
Types of changes
Bug fix. We should publish this as soon as possible.
Checklist:
*.native.jsfiles for terms that need renaming or removal).