Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical toolbar in “Zoom Out” position for non fullwidth blocks #63463

Closed
stokesman opened this issue Jul 11, 2024 · 3 comments
Closed

Vertical toolbar in “Zoom Out” position for non fullwidth blocks #63463

stokesman opened this issue Jul 11, 2024 · 3 comments
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@stokesman
Copy link
Contributor

Description

The new vertical toolbar from #60123 is cool. I've noticed that on a theme with a dark background when a content block that isn’t full width is selected, the toolbar sits over the canvas and can be pretty much invisible. I would expect that the toolbar should always have good visibility regardless of the theme’s background.

Step-by-step reproduction instructions

  1. Select a theme with a dark background or change your theme’s background to a dark one
  2. Open the Inserter, go to the Patterns tab and select a pattern category
  3. Select a block that is not full-width
  4. Notice the toolbar buttons are hard (maybe impossible) to see

Screenshots, screen recording, code snippet

image

Environment info

  • WP 6.5 / Gutenberg Trunk / Twenty Twenty-Four
  • Chrome
  • Desktop macOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@stokesman stokesman added [Type] Bug An existing feature does not function as intended Needs Design Needs design efforts. [Feature] Zoom Out labels Jul 11, 2024
@richtabor richtabor removed the Needs Design Needs design efforts. label Jul 13, 2024
@richtabor
Copy link
Member

I removed the Needs Design label; this is a bug as the vertical toolbar should always reside outside the site contents. Instead it looks the the vertical toolbar is always to the left of the content, rather than always on the outside.

cc @scruffian @MaggieCabrera

@richtabor richtabor changed the title Vertical toolbar in “Zoom Out” visibility on themes with dark backgrounds Vertical toolbar in “Zoom Out” position for non fullwidth blocks Jul 16, 2024
@richtabor
Copy link
Member

Ideally the toolbar is not reliant on the width of the block, but the canvas itself. Another alternative is to only have the toolbar render for fullwidth blocks (at least a temporary measure to try first). cc @MaggieCabrera

@scruffian
Copy link
Contributor

Fixed by #63650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
Development

No branches or pull requests

3 participants