-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try a generic block editor module #13088
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
150e0ed
Try a generic block editor module
youknowriad 44ca3aa
Migrate persisted block usage
youknowriad f6a0e17
Block Editor: Remove history handling as managed by Editor
aduth 3e0fc58
Block Editor: Separate onChange from onInput as committing change
aduth 25772de
Move state.editor.blocks to state.blocks
youknowriad 2d06c4f
Avoid rerendering the editor if the settings didn't change
youknowriad ba7b92d
Switch the position of the isSyncingBlockValue flag
youknowriad 30d4f81
Block Editor: Reimplement persistent block change as reducer state
aduth d904406
Block Editor: Avoid handling non-updating actions in isUpdatingSameBl…
aduth f1dff88
fixup: Block Editor: Reimplement persistent block change as reducer s…
aduth 97bdb82
Undo level and block change in the same dispatch
youknowriad 3a0ee11
More stable preformatted e2e test
youknowriad 5aa7de7
Try a more stable container blocks test
youknowriad 01a154c
Fix RichText undo interactions
youknowriad d463228
More stable preformatted block test
youknowriad 14e2dfa
Avoid unnecessary getBlocks selector invalidation
youknowriad 3ebc2c6
Try fixing initial dirtiness
youknowriad 724b38f
Block Editor: Align hasSameKeys to editor implementation
aduth bd355c5
Editor: Rename resetEditorBlocks undo argument as unstable
aduth 9aecc91
Block Editor: Rename markLastChangeAsPersistent as unstable
aduth 184807b
Block Editor: Assure lastAction is non-undefined
aduth 123f7b2
Editor: Assign dependencies upon block-editor
aduth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Switch the position of the isSyncingBlockValue flag
- Loading branch information
commit ba7b92dfd749c3bbbb41771976549b1faf97e717
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we switch these two lines (same in the next check)? since
onChange
could potentially trigger the didUpdate synchronously?