Size Change: +2.56 kB (0%)

Total Size: 1.15 MB

_{compressed-size-action}

Thanks for the detailed testing @ciampo! I'll take a closer look at the insertion point warnings.

In terms of the bundle-size increase, I suppose we could look into replacing the last instances of react-spring usage before attempting to updating the major version here.

@ciampo I wasn't having luck triggering the animation warning for insertion point. Would it be possible to add a quick video?

With regards to "Can't perform React state update on an unmounted component" warnings, it looks like we have several of these issues (and it's unrelated to the library upgrade). I'm pulling out fixes for the ones I spotted in separate PRs.

Took it for a quick spin, and I don't see any difference in animation 👍 👍

Hmm is there any way to manually re-trigger the bundle size calculation? It doesn't look like the bot saw that much of a difference:

I wasn't having luck triggering the animation warning for insertion point. Would it be possible to add a quick video?

If you refer to the insertion point animation (which I flagged as potentially a bit janky) triggered when hovering with the mouse over the space in between two blocks, I checked it again today and wasn't able to reproduce the jankiness.

In case you referred to the insertion point that shows during a drag and drop, it looks like you already opened a PR for it!

If you instead referred to the animation from page "instance" editing to page "template" editing also seems good, although I can see a warning and an error in the console when triggering the animation, here's a video:

(it could be 2 separate problems: the memory leak and an animation on the padding value which should be done via CSS, both can be tackled separately)

Hmm is there any way to manually re-trigger the bundle size calculation? It doesn't look like the bot #38999 (comment):

Could it be because the @wordpress/components package only exports motion and AnimatePresence ?

I can see a warning and an error in the console when triggering the animation, here's a video:

Thanks for the video, I'll look into that warning in another PR. It's also visible in other branches.

Could it be because the @wordpress/components package only exports motion and AnimatePresence ?

Possibly, let me try some test commits.

The animation warning can be ignored in the context of this PR, but should be addressed in a follow up.

For optimum performance, animations should target opacity, or things that can be modified via the transform prop (like scale, width, height etc). The TL;DR of why is that this only triggers a compositor change, without triggering layout or paint calculations. The current values here work, but Framer is giving us a warning, so the visual-editor animation should be rethought.

Thanks for the video, I'll look into that warning in another PR. It's also visible in other branches.

Thank you for the investigation!

The TL;DR of why is that this only triggers a compositor change, without triggering layout or paint calculations. The current values here work, but Framer is giving us a warning, so the visual-editor animation should be rethought.

Exactly! This animation should be re-written using only the transform and opacity CSS props.

@ciampo I updated the branch to use 6.2.8 instead of 6.2.7. I think the last hesitation we had for the upgrade was the bundle size difference. From the last size-check run though, it still looks like 1% difference. Shall we give this a try, unless you had additional feedback?

https://github.com/WordPress/gutenberg/runs/5394838851?check_suite_focus=true

Had another look, everything seems good to me!

Thanks for the really detailed review @ciampo! I'll try landing, and will keep an eye out for any necessary follow ups.