Hi @sandeld,
Thanks for your question.
I thought it sounded weird at first as I didn’t see this issue before, but indeed I was able to replicate it on my installation.
The strange thing is that it happens only on free version of the plugin, even though the code should be pretty much as the pro version as far as I know.
Anyways, I have passed this over to our developers so they can check it out in depth.
About your issue with smushing, can you try opening Chrome console by pressing Ctrl Shift J (on Windows) or Ctrl Option J (on Mac) and then click on the button, it should show some red errors in there which could shed some light on what’s going on.
Let us know if you do see any errors there and perhaps grab us a screenshot of the console so we can check it out.
Cheers,
Predrag
Thanks for the fast reply.
Here is a screenshot of the error when I click the Bulk Smush button:
Hey @sandeld,
Hope you’re well.
Looks like some other plugins or theme js files conflicting and cause js errors. Can you try conflict tests? You need to deactivate all plugins except Smush and activate Twenty Seventeen theme. Then try bulk smush again. If it helps activate back everything one by one and try bulk smush button every time to understand which product conflicting. And let us know!
Because these tests can cause data loss, you need to back up your website first and then try conflict tests.
Cheers,
Oguz
Ok, interestingly enough. I was going to do a major site-speed update in a couple of days anyways so this will be no problem to do at the same time. One question though…
If you said that you can recreate the problem in your test environment, then it doesn’t seem like a plugin conflict is necessarily causing it since you don’t have the same plugins as I do. Just because my console window shows there *are* conflicts wouldn’t necessarily mean it *is* a conflicting creating it. Ya know?
@sandeld,
Regarding the translations – after you change the language in your profile, you need to go to wp-admin/update-core.php and update translations from there. WordPress will download the translation files (if available) for the selected language.
Best regards,
Anton
Mmmm, that seems a little intrusive for fairly basic functionality. Every other plugin and theme works flawlessly for handling the different languages, i.e. Site language is Spanish, and my user profile is English. I’ve never had to update ANY php file just to get that to work. It’s only this plugin that is not displaying the language correctly.
@sandeld,
In what way is that intrusive? You are downloading update for all the plugins, are you not? Same thing happens with translations. That is how WordPress works. You probably just haven’t noticed this, as translations are usually auto updated during plugin updates.
You can read about it in more detail here: https://make.wordpress.org/meta/handbook/documentation/translations/
Best regards,
Anton
Now you’ve really confused me. Downloading update for all the plugins? What?
Never in my 10 years of WordPress usage have I ever needed to go into a php file hosted on my server just to support site language vs. user language. Based on that and your comment about “that’s just how WordPress works” makes me think you don’t actually understand the actual problem. And especially given since your colleague, the first person to reply, said he could reproduce the error in his test environment.
@sandeld,
I think you misunderstood me. Sorry for that. Of course, you don’t need to go into any php files. I posted the path as part of the link to the Dashboard – Updates page. When you go to that page and check for updates (after switching the language in your profile), you will get an update for Smush translations. Click “Update” and that’s it – you have Smush in your selected language.
I believe, the confirmed issue was that after switching the language in your profile, Smush doesn’t auto download the required translation files.
Best regards,
Anton
Yup, still confused. So just for the fun of it, I changed my user language to Spanish, checked the update page, visited the Smush plugin settings, changed my language back to English, visited the update page, and revisited the Smush plugin settings.
The entire time Smush remained in Spanish while the rest of the site changed.
The thing is, I installed Smush in English, I originally used it in English, and I’ve done many multiple updates of Smush while in English. The entire time, the site language has been in Spanish and that has never changed.
The only thing that has changed is the visible language of your plugin. So I’m at a loss…
Hey @sandeld,
I found the issue that you are talking about. The next release is already in testing, this will make it to the release after. For now, if you wish to fix this manually, you can open the file wp-smushit/wp-smush.php and on line 203 replace
__( 'Get Fast', 'wp-smushit' ),
with
'Get Fast',
Best regards,
Anton
That did the trick, thanks!
I’m going to be doing a bunch of other site maintenance and updates this weekend so I will report back on my findings with the conflict for why the Bulk Smush button isn’t working for me.
Hello @sandeld
Hope you are doing great!
We’ve not heard from you in a while. I’ve marked this ticket as resolved for now, but if you need anything else at all, we’re here for you, please just reopen the ticket or create a new one.
Kind regards,
Nastia
Oof! I completely forgot about this, and when I was doing the site maintenance, I ran into a bunch of other problems.
Anyways, the button is still broken which means there’s still a conflict, but at least the language thing is fixed.
Hey @sandeld,
Hope you’re well.
Did you try plugin conflict test for the bulk smush feature as I explain in the first answer of mine? Predrag told can replicate translation issue but we can’t bulk smush button issue.
Cheers,
Oguz
