Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #2, with one more possible change. This is a bit of extra typing, but is much clearer; I could see the following to be rather confusing if this is named
counts
instead ofeffective_counts
, since it's not always the true number of counts, but an effective count calculation. For a user filling a weighed sum or weighed mean histogram, the fact that ".counts" is neither the number of times filled nor the weighted number of times filled is likely to be quite a surprise. While if it was called "effective_counts", they would be more likely to suspect that it's a special computed quantity and not just the raw or weighted counts.Followup to #2, CC @HDembinski and @jpivarski.