Parse class with capitol letter after instanceof correctly #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
force-pushed
the
roblou/instanceOfClass
branch
from
682fdad
to
be86fff
Compare
Ingramz
suggested changes
Mar 5, 2020
grammars/php.cson
Outdated
| @@ -728,11 +728,11 @@ | |||
| 'name': 'keyword.operator.bitwise.php' | |||
| } | |||
| { | |||
| 'begin': '(?i)\\b(instanceof)\\s+(?=[\\\\$a-z_])' | |||
| 'begin': '(?i)\\b(instanceof)\\s+(?=[\\\\$a-zA-Z_])' | |||
There was a problem hiding this comment.
Modifier in front is already marks this expression case insensitive, so this change should not be needed.
There was a problem hiding this comment.
It does fix the issue though, hm...
There was a problem hiding this comment.
Oh, only the second line is needed
There was a problem hiding this comment.
Yeah, I realized that it could be read like that, sorry about that.
Ingramz
approved these changes
Mar 5, 2020
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description of the Change
It looks like the original author of this section did intend to parse the thing after
instanceofcorrectly but only includeda-znotA-Za-z. You can see that this does work as expected with class names starting with a lowercase letter.Benefits
Show correct coloring for the class name
Possible Drawbacks
I think this is fairly straightforward
Applicable Issues
#225
microsoft/vscode#88441