Add devtools catch #1137
Merged
Add devtools catch #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadick254
approved these changes
Sep 30, 2020
|
|
||
| // The CI on Atom has been failing with this package. Experiments | ||
| // indicate the dev tools were being opened, which caused test | ||
| // failures. Dev tools are meant to be triggered on an uncaught | ||
| // exception. | ||
| // | ||
| // These failures are flaky though, so an exact cause | ||
| // has not yet been found. For now the following is added | ||
| // to reduce the number of flaky failures, which have been | ||
| // causing false failures on unrelated Atom PRs. | ||
| // | ||
| // See more in https://github.com/atom/atom/pull/21335 |
There was a problem hiding this comment.
Thanks for adding this context @Aerijo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Requirements
Description of the Change
Reduces flaky test failures on the main Atom repo CI. The summary is that an uncaught exception is triggering dev tools, which breaks tests. See atom/atom#21335 for more.
Alternate Designs
Fixing the root of the problem. But that's a lot more difficult, seeing as the cause hasn't been completely determined yet. Investigations are welcome!
Benefits
Reduced false CI failures on main repo PRs
Possible Drawbacks
This is only masking the deeper issue, so isn't a fix and should not be treated as such.
Applicable Issues
None. It does not completely resolve any issues.