Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mailcatcher install command on Docker build #721

Merged
merged 1 commit into from Jan 19, 2022

Conversation

timiwahalahti
Copy link
Collaborator

@timiwahalahti timiwahalahti commented Jan 8, 2022

On Docker build, mailcatcher is installed from gem. Previously there were options --no-ri --no-rdoc given, but those are deprecated and the build process didn't work as gem install failed. Changed the options to --no-document which seemed to do the same thing.

How to test the changes in this Pull Request:

  1. Try to run Docker build with RUN gem install mailcatcher --no-ri --no-rdoc > fails
  2. Now run Docker build with RUN gem install mailcatcher --no-document > works

ryelle
ryelle approved these changes Jan 19, 2022
Copy link
Contributor

@ryelle ryelle left a comment

This fixes the image build 👍🏻

@ryelle ryelle merged commit a1e259c into WordPress:production Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants