Changeset 49843

Timestamp:

12/20/2020 02:35:58 PM (19 months ago)

Author:

johnbillion

Message:

Query: Ensure the author archive title always shows the name of the queried author, regardless of whether there are results.

This brings the behaviour inline with the <title> element of the page which always shows the author name.

Props Tkama, subrataemfluence

Fixes #44183

Location:

trunk

Files:

• src/wp-includes/class-wp.php (modified) (1 diff)
• tests/phpunit/tests/general/template.php (modified) (1 diff)

trunk/src/wp-includes/class-wp.php

@@ -598 +598 @@
         }
 
-        if ( $wp_query->is_author() && isset( $wp_query->post ) ) {
-            $GLOBALS['authordata'] = get_userdata( $wp_query->post->post_author );
+        if ( $wp_query->is_author() ) {
+            $GLOBALS['authordata'] = get_userdata( get_queried_object_id() );
         }
     }

trunk/tests/phpunit/tests/general/template.php

@@ -590 +590 @@
         );
     }
+
+    /**
+     * @ticket 44183
+     */
+    function test_get_the_archive_title_is_correct_for_author_queries() {
+        $user_with_posts = $this->factory()->user->create_and_get(
+            array(
+                'role' => 'author',
+            )
+        );
+        $user_with_no_posts = $this->factory()->user->create_and_get(
+            array(
+                'role' => 'author',
+            )
+        );
+
+        $this->factory()->post->create( [
+            'post_author' => $user_with_posts->ID,
+        ] );
+
+        // Simplify the assertion by removing the default archive title prefix:
+        add_filter( 'get_the_archive_title_prefix', '__return_empty_string' );
+
+        $this->go_to( get_author_posts_url( $user_with_posts->ID ) );
+        $title_when_posts = get_the_archive_title();
+
+        $this->go_to( get_author_posts_url( $user_with_no_posts->ID ) );
+        $title_when_no_posts = get_the_archive_title();
+
+        // Ensure the title is correct both when the user has posts and when they dont:
+        $this->assertSame( $user_with_posts->display_name, $title_when_posts );
+        $this->assertSame( $user_with_no_posts->display_name, $title_when_no_posts );
+    }
 }