Github review process #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added some information about the review process. Two or one approval needed.
getsource
reviewed
Jun 2, 2022
get-involved.md
Outdated
| @@ -22,6 +22,8 @@ The first thing you'll have to do is [visit the repository page](https://github. | |||
|
|
|||
| After you submit an issue, we can discuss together the suggested changes. | |||
|
|
|||
| Once a PR is submitted, it will require an approval process. By default, once it is submitted it will require review and approval by two people from the Hosting team. In cases where there are PRs related to corrections or internal operational elements, only one review will be required by someone from the team. | |||
There was a problem hiding this comment.
Maybe something that references the PR also being created by someone from the Hosting Team?
There was a problem hiding this comment.
I think the new one is more clarifying:
Once a PR is submitted, it will require an approval process. By default, once it is submitted, it will require review and approval by two people from the Hosting team. In cases where there are PRs related to corrections or internal operational elements, created by someone from the Hosting Team, only one review will be required.
That's should improve the explanation on who need one or tow approvals.
Crixu
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We added some information about the review process. Two or one approval needed.