selectors: fix missing bounds check on int conversion #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were parsing a 64-bit integer here and converting to a u32 without a bounds check. This is obviously wrong, so drop the bit size on the ParseInt call down to 32 and make it ParseUint. Additionally, split up signed and unsigned cases in parseMatchValues() so that we can properly parse the signed/unsigned integer types. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/fix-codeql-lints
branch
from
88d99b9
to
c40302f
Compare
michi-covalent
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue revealed by the new codeql lints ci job.
We were parsing a 64-bit integer here and converting to a u32 without a bounds check. This
is obviously wrong, so drop the bit size on the ParseInt call down to 32 and make it
ParseUint. Additionally, split up signed and unsigned cases in parseMatchValues() so that
we can properly parse the signed/unsigned integer types.
Signed-off-by: William Findlay [email protected]