Skip to content

/ cartridge

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect test coverage #482

Merged
merged 2 commits into from Feb 7, 2020
Merged

Collect test coverage #482

merged 2 commits into from Feb 7, 2020

Conversation

@printercu
Copy link
Contributor

@printercu printercu commented Jan 20, 2020 •
edited by rosik

Close #88
@printercu printercu force-pushed the luacov branch from dd96099 to 4353605 Jan 20, 2020
@printercu
Copy link
Contributor Author

@printercu printercu commented Jan 22, 2020

Looks like some tests are failed because everything got slightly slower, this is not luatest issue. Should I close this pr?
@rosik
Copy link
Member

@rosik rosik commented Jan 22, 2020

Looks like some tests are failed because everything got slightly slower, this is not luatest issue. Should I close this pr?

No, I'm going to re-check it soon and tune timeouts
@rosik rosik force-pushed the luacov branch from d6f8535 to d930781 Feb 3, 2020
@rosik rosik changed the title WIP: Collect test coverage Collect test coverage Feb 3, 2020
@mmelentiev-mail @rosik
Collect test coverage
69a2228
@rosik rosik force-pushed the luacov branch from d930781 to 6e7a12c Feb 7, 2020
@rosik
Disable coverage in CI
Loading status checks…
11a432e 
It reveals too many flaky tests
@rosik rosik force-pushed the luacov branch from 6e7a12c to 11a432e Feb 7, 2020
@rosik
rosik approved these changes Feb 7, 2020
View changes
@rosik rosik merged commit ccb49d8 into master Feb 7, 2020
1 check passed
1 check passed
ci/gitlab/luacov Pipeline passed on GitLab
Details
@rosik rosik deleted the luacov branch Feb 7, 2020
DHorrible added a commit that referenced this pull request Feb 8, 2020
@printercu @mmelentiev-mail
@rosik @DHorrible
Collect test coverage (#482)
47a45d1 
Make test coverage collection more handsome, but don't enable it in
Gitlab CI yet: it reveals a lot of flaky tests and complicates merging PRs.

Close #88

Co-authored-by: mmelentiev-mail <[email protected]>
Co-authored-by: Yaroslav Dynnikov <[email protected]>
DHorrible added a commit that referenced this pull request Feb 14, 2020
@printercu @mmelentiev-mail
@rosik @DHorrible
Collect test coverage (#482)
9121444 
Make test coverage collection more handsome, but don't enable it in
Gitlab CI yet: it reveals a lot of flaky tests and complicates merging PRs.

Close #88

Co-authored-by: mmelentiev-mail <[email protected]>
Co-authored-by: Yaroslav Dynnikov <[email protected]>
DHorrible added a commit that referenced this pull request Feb 14, 2020
@printercu @mmelentiev-mail
@rosik @DHorrible
Collect test coverage (#482)
f7c172e 
Make test coverage collection more handsome, but don't enable it in
Gitlab CI yet: it reveals a lot of flaky tests and complicates merging PRs.

Close #88

Co-authored-by: mmelentiev-mail <[email protected]>
Co-authored-by: Yaroslav Dynnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosik rosik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Measure integration tests coverage
3 participants
@printercu @rosik @mmelentiev-mail
You can’t perform that action at this time.