Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pause failover at runtime #1783

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Allow to pause failover at runtime #1783

merged 6 commits into from
Mar 23, 2022

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Mar 22, 2022 •
edited
Loading

I didn't forget about

  • Tests
  • Changelog
  • Documentation

Close #1763

patiencedaur
patiencedaur reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some grammar-related comments. There is a place where I don't understand what you're saying.

cartridge/failover.lua Outdated Show resolved Hide resolved
doc/schema.graphql Outdated Show resolved Hide resolved
doc/schema.graphql Outdated Show resolved Hide resolved
doc/schema.graphql Outdated Show resolved Hide resolved
rst/topics/failover.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@yngvar-antonsson yngvar-antonsson merged commit 44726e6 into master Mar 23, 2022
@yngvar-antonsson yngvar-antonsson deleted the stifle-failover branch March 23, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filonenko-mikhail filonenko-mikhail filonenko-mikhail approved these changes

@patiencedaur patiencedaur patiencedaur left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to pause failover at runtime
3 participants
@yngvar-antonsson @filonenko-mikhail @patiencedaur