Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation build warnings #1401

Merged
merged 8 commits into from
May 13, 2021
Merged

Conversation

Onvember
Copy link
Contributor

@Onvember Onvember commented Apr 29, 2021

This PR fixes some warnings while building the docs.

fixes part of #903

@Onvember Onvember requested a review from rosik April 29, 2021 17:52
Copy link
Contributor

@rosik rosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase it on top of the fresh master branch.

@@ -370,7 +370,7 @@ Fixed

- Properly handle nested input object in GraphQL:

.. code-block:: graphql
.. code-block:: text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not fair

Copy link
Contributor

@NickVolynkin NickVolynkin May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no graphql lexer provided with Pygments. However, we can try using https://pypi.org/project/pygments-graphql/.

rst/cartridge_dev.rst Outdated Show resolved Hide resolved
@Onvember Onvember force-pushed the onvember/fix-doc-build-warnings branch 3 times, most recently from 5285127 to 457d755 Compare May 4, 2021 09:42
@rosik rosik force-pushed the onvember/fix-doc-build-warnings branch from 0cc2903 to ac0ce6f Compare May 4, 2021 11:27
@rosik rosik merged commit b8bc178 into master May 13, 2021
@rosik rosik deleted the onvember/fix-doc-build-warnings branch May 13, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants