Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stateboard defaults #1225

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Add stateboard defaults #1225

merged 2 commits into from
Jan 15, 2021

Conversation

Steap2448
Copy link
Contributor

@Steap2448 Steap2448 commented Jan 15, 2021 •
edited by rosik
Loading

Stateboard defaults have been added to the failover_params query:

{
  "tarantool_params": {
    "uri": "tcp://localhost:4401",
    "password": ""
  }
}

I didn't forget about

  • Tests
  • Changelog (unnecessary)
  • Documentation (unnecessary)

Close #1189

@Steap2448 Steap2448 force-pushed the 1189-stateboard-defaults branch 3 times, most recently from 2fcdde4 to 31a8cc0 Compare January 15, 2021 01:10
@rosik rosik self-requested a review January 15, 2021 09:07
@rosik rosik marked this pull request as ready for review January 15, 2021 09:07
rosik
rosik reviewed Jan 15, 2021
View reviewed changes
test/compatibility/config_test.lua Show resolved Hide resolved
webui/cypress/integration/failover.spec.js Outdated Show resolved Hide resolved
cartridge/topology.lua Outdated Show resolved Hide resolved
@Steap2448 Steap2448 requested a review from rosik January 15, 2021 12:17
@rosik rosik requested a review from dokshina January 15, 2021 15:07
@rosik rosik merged commit 63235d9 into master Jan 15, 2021
@rosik rosik deleted the 1189-stateboard-defaults branch January 15, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosik rosik rosik approved these changes

@dokshina dokshina dokshina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2pt] Add defaults for stateboard config
3 participants
@Steap2448 @rosik @dokshina