The feedback link currently displays to anyone visiting the page, even if they don't have permission to view it:
We should only show it to people who have access.
Tchanders | |
Apr 10 2019, 6:10 PM |
F28603547: image.png | |
Apr 10 2019, 6:10 PM |
The feedback link currently displays to anyone visiting the page, even if they don't have permission to view it:
We should only show it to people who have access.
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/extensions/WikimediaMessages | master | +4 -1 | Remove Special:Block feedback link for those who don't have access |
Assuming this is about MediaWiki-User-management hence adding MediaWiki-User-management tag.
Change 514629 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/WikimediaMessages@master] Remove Special:Block feedback link for those who don't have access
Change 514629 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Remove Special:Block feedback link for those who don't have access
I don't see the link when I am an anonymous user or a non-admin user. I do when I am logged in as an admin.
I neither situation do I see errors in the browser console, so I assume nothing else broke.
I notice that I do see the link if I am an admin user who is blocked, even though being blocked means I cannot use Special:Block. I am assuming this is not a major problem.
I notice that I do see the link if I am an admin user who is blocked, even though being blocked means I cannot use Special:Block. I am assuming this is not a major problem.
Hmm, that was unintentional, but might be a bit messy to correct. It wouldn't be as simple as checking for a block, because there are cases where a blocked admin should be able to access Special:Block (e.g. T208965, T150826). So to make sure people can see the feedback link iff they can access the blocking form, we'd have to keep up with those and any other cases in the WikimediaMessages hook. I agree it might be preferable to live with this small inconsistency.
(Didn't mean to remove the points value there, but since I did, replacing with something more accurate...)