Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#39426 closed defect (bug) (duplicate)

Adding new widget in Customizer shows Delete control instead of Remove

Reported by: monikarao Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: has-patch reporter-feedback needs-testing
Focuses: ui Cc:

Description

I noticed that in Customizer, existing widgets are showing red colored "Remove" control but when we add new widget by clicking "Add a Widget", it shows "Delete" control instead of "Remove".

Please refer attached screenshots "customizer-existing-widget.png" and "customizer-new-widget.png"

Attachments (4)

customizer-existing-widget.png (27.0 KB) - added by monikarao 5 years ago.
Customizer - "Remove" control in existing widget
customizer-new-widget.png (15.4 KB) - added by monikarao 5 years ago.
Customizer - "Delete" control in newly added widget
39426.diff (581 bytes) - added by bhargavbhandari90 5 years ago.
Changed text from "Delete" to "Remove"
39426.2.diff (762 bytes) - added by jainnidhi 5 years ago.

Download all attachments as: .zip

Change History (9)

@monikarao
5 years ago

Customizer - "Remove" control in existing widget

@monikarao
5 years ago

Customizer - "Delete" control in newly added widget

@bhargavbhandari90
5 years ago

Changed text from "Delete" to "Remove"

#1 in reply to: ↑ description @bhargavbhandari90
5 years ago

  • Keywords has-patch reporter-feedback added

Replying to monikarao:

I noticed that in Customizer, existing widgets are showing red colored "Remove" control but when we add new widget by clicking "Add a Widget", it shows "Delete" control instead of "Remove".

Please refer attached screenshots "customizer-existing-widget.png" and "customizer-new-widget.png"

Yes @monikarao it should be same text. Added a patch for this. This should be fine now.

#2 follow-ups: @ibachal
5 years ago

@bhargavbhandari90 As per your patch, this will also impact the controls in backend widgets Appearance > Widgets.

@jainnidhi
5 years ago

#3 in reply to: ↑ 2 @jainnidhi
5 years ago

  • Keywords needs-testing added

So, we need to replace "Remove" with "Delete". Patch "39426.2.diff" is attached. It will change the control "Remove" to "Delete" only in Customizer widgets.

Replying to ibachal:

@bhargavbhandari90 As per your patch, this will also impact the controls in backend widgets Appearance > Widgets.

Last edited 5 years ago by jainnidhi (previous) (diff)

#4 in reply to: ↑ 2 @bhargavbhandari90
5 years ago

Replying to ibachal:

@bhargavbhandari90 As per your patch, this will also impact the controls in backend widgets Appearance > Widgets.

I did it for making same word everywhere.

#5 @westonruter
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Thanks for the report and conversation. However, the Delete vs Remove distinction is intentional. See #27575.

Note: See TracTickets for help on using tickets.