Making WordPress.org

Opened 8 weeks ago

Last modified 7 weeks ago

#6049 reopened defect (bug)

wordpress.org/themes/twentytwenty incorrectly shows Template: Cover

Reported by: bobbingwide Owned by: Otto42
Milestone: Priority: normal
Component: Theme Directory Keywords: needs-patch
Cc:

Description

Marius Jensen said

I see why it happens, if that helps?

If you wouldn't mind, creating a meta ticket is the best solution, as it's the style.css parser picking up the table of contents section with a. Template: Cover Template , and parsing it as Template: cover

Change History (6)

#1 @Otto42
8 weeks ago

  • Owner set to Otto42
  • Status changed from new to accepted

I'll work on correcting the org database. It will take time for the caches to clear.

Last edited 8 weeks ago by Otto42 (previous) (diff)

#2 @Otto42
8 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Corrected entry in database. Cache refresh will take some time, so it may show up again before it goes away fully in a day or two.

#3 @Otto42
8 weeks ago

  • Keywords needs-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening. This isn't seemingly a problem with core anymore, because they switched from using the now deprecated get_theme_data function to using the WP_Theme class exclusively.

We have a copied/modified version of this function in the theme-directory plugin, so should probably consider modifying this to also use the WP_Theme class where possible, to ensure future compatibility with core changes.

Last edited 8 weeks ago by Otto42 (previous) (diff)

#4 @desrosj
8 weeks ago

#6057 was marked as a duplicate.

#5 @Otto42
7 weeks ago

Yes, the cache is being persistently annoying here. But it is fixed in the database, confirmed, and it will go away eventually. Promise. I'm also looking at better ways of kicking this cache in particular.

In the meantime, if we upload a new version of 2020 then this will recur, but at least we know why now, and can work around it. A fix will need some minor changes to the theme directory code.

#6 @dd32
7 weeks ago

I've cleared the memcache & WP caches, they would've lasted for between 7-31 days otherwise.

(It no longer shows Cover as it's parent now)

Last edited 7 weeks ago by dd32 (previous) (diff)
Note: See TracTickets for help on using tickets.