Changeset 50153

Timestamp:

02/02/2021 06:11:26 PM (14 months ago)

Author:

SergeyBiryukov

Message:

Login and Registration: Improve the UX of the Reset Password screen.

Previously, it was unclear that the displayed password is only being suggested and should be saved by clicking the Reset Password button.

This adds separate Generate Password and Save Password buttons, for clarity.

Props xkon, estelaris, jaymanpandya, hedgefield, audrasjb, erichmond, magicroundabout, lukecavanagh, knutsp, tinodidriksen, nico_martin, markhowellsmead, kara.mcnair, e_baker, pixelverbieger, souri_wpaustria, megabyterose, poena, whyisjake.
Fixes #39638.

Location:

trunk/src

Files:

• js/_enqueues/admin/user-profile.js (modified) (2 diffs)
• wp-admin/admin-ajax.php (modified) (1 diff)
• wp-admin/includes/ajax-actions.php (modified) (2 diffs)
• wp-login.php (modified) (2 diffs)

trunk/src/js/_enqueues/admin/user-profile.js

@@ -158 +158 @@
             $cancelButton;
 
-        $pass1Row = $( '.user-pass1-wrap, .user-pass-wrap' );
+        $pass1Row = $( '.user-pass1-wrap, .user-pass-wrap, .reset-pass-submit' );
 
         // Hide the confirm password field when JavaScript support is enabled.
@@ -462 +462 @@
     } );
 
+    /*
+     * We need to generate a password as soon as the Reset Password page is loaded,
+     * to avoid double clicking the button to retrieve the first generated password.
+     * See ticket #39638.
+     */
+    $( document ).ready( function() {
+        if ( $( '.reset-pass-submit' ).length ) {
+            $( '.reset-pass-submit button.wp-generate-pw' ).trigger( 'click' );
+        }
+    });
+
 })(jQuery);

trunk/src/wp-admin/admin-ajax.php

@@ -165 +165 @@
 }
 
+add_action( 'wp_ajax_nopriv_generate-password', 'wp_ajax_nopriv_generate_password' );
+
 add_action( 'wp_ajax_nopriv_heartbeat', 'wp_ajax_nopriv_heartbeat', 1 );
 

trunk/src/wp-admin/includes/ajax-actions.php

@@ -13 +13 @@
 
 /**
- * Ajax handler for the Heartbeat API in
- * the no-privilege context.
+ * Ajax handler for the Heartbeat API in the no-privilege context.
  *
  * Runs when the user is not logged in.
@@ -3978 +3977 @@
 
 /**
+ * Ajax handler for generating a password in the no-privilege context.
+ *
+ * @since 5.7.0
+ */
+function wp_ajax_nopriv_generate_password() {
+    wp_send_json_success( wp_generate_password( 24 ) );
+}
+
+/**
  * Ajax handler for saving the user's WordPress.org username.
  *

trunk/src/wp-login.php

@@ -853 +853 @@
         wp_enqueue_script( 'user-profile' );
 
-        login_header( __( 'Reset Password' ), '<p class="message reset-pass">' . __( 'Enter your new password below.' ) . '</p>', $errors );
+        login_header( __( 'Reset Password' ), '<p class="message reset-pass">' . __( 'Enter your new password below or generate one.' ) . '</p>', $errors );
 
         ?>
@@ -899 +899 @@
             ?>
             <input type="hidden" name="rp_key" value="<?php echo esc_attr( $rp_key ); ?>" />
-            <p class="submit">
-                <input type="submit" name="wp-submit" id="wp-submit" class="button button-primary button-large" value="<?php esc_attr_e( 'Reset Password' ); ?>" />
+            <p class="submit reset-pass-submit">
+                <button type="button" class="button wp-generate-pw hide-if-no-js" aria-expanded="true"><?php _e( 'Generate Password' ); ?></button>
+                <input type="submit" name="wp-submit" id="wp-submit" class="button button-primary button-large" value="<?php esc_attr_e( 'Save Password' ); ?>" />
             </p>
         </form>