Fix global styles loading logic #38745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
youknowriad,
and
tellthemachines (assigned from WordPress/gutenberg-core)
and removed request for
|
Thanks André and Andrei |
|
For awareness: PR for backporting this to core at WordPress/wordpress-develop#2303 (related trac ticket). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Part of #38434
The global styles stylesheet should be loaded using this logic, no matter the WordPress version:
<head>.<head>.<body>.In
trunkit's not working as expected and shows differences between WordPress 5.8 and WordPress 5.9.Backport
The parts of this that need backporting to core are in this PR already WordPress/wordpress-develop#2303
How to test
Use TwentyTwenty, unmodified. Test both in WordPress 5.8 and WordPress 5.9.
global-styles-inline-cssembedded stylesheet is loaded in the head.Use TwentyTwenty after opting into loading separate assets. Test both in WordPress 5.8 and WordPress 5.9.
add_filter( 'should_load_separate_core_block_assets', '__return_true' );in TwentyTwenty'sfunctions.php.global-styles-inline-cssembedded stylesheet is loaded in the body.Use EmptyTheme. Test both in WordPress 5.8 and WordPress 5.9.
global-styles-inline-cssembedded stylesheet is loaded in the head.