Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimize build #1449

Merged
merged 1 commit into from Feb 25, 2022
Merged

ci: optimize build #1449

merged 1 commit into from Feb 25, 2022

Conversation

splincode
Copy link
Member

@splincode splincode commented Feb 23, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

image

image

Build time: 130 sec

What is the new behavior?

image

image

Decompose 2.29Mb into 2 files
Build time: 97 sec

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

@lumberjack-bot lumberjack-bot bot commented Feb 23, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 23, 2022

Visit the preview URL for this PR (updated for commit c1b1610):

https://taiga-ui--pr1449-splincode-feat-optim-21se4dv2.web.app

(expires Sat, 26 Feb 2022 08:12:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

@codecov codecov bot commented Feb 23, 2022

Codecov Report

Merging #1449 (c1b1610) into main (dbc66ba) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
- Coverage   64.79%   64.76%   -0.04%     
==========================================
  Files         808      809       +1     
  Lines        9042     9053      +11     
  Branches     1779     1782       +3     
==========================================
+ Hits         5859     5863       +4     
- Misses       2747     2753       +6     
- Partials      436      437       +1     
Flag Coverage Δ
addon-charts 74.69% <ø> (ø)
addon-doc 25.84% <ø> (ø)
addon-editor 46.05% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 82.85% <ø> (ø)
core 68.81% <ø> (ø)
kit 63.28% <ø> (-0.07%) ⬇️
summary 64.76% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/kit/components/combo-box/combo-box.component.ts 53.03% <0.00%> (-3.04%) ⬇️
.../kit/components/line-clamp/line-clamp.directive.ts 6.45% <0.00%> (ø)
projects/kit/components/slider/slider-options.ts 80.00% <0.00%> (ø)
projects/kit/components/slider/slider.component.ts 84.21% <0.00%> (+0.87%) ⬆️
...dropdown-selection/dropdown-selection.directive.ts 4.25% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc66ba...c1b1610. Read the comment docs.

@splincode splincode force-pushed the splincode/feat/optimize branch from 368935e to 028cc2e Feb 23, 2022
package.json Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@splincode splincode force-pushed the splincode/feat/optimize branch from 028cc2e to 5c6f131 Feb 24, 2022
@splincode splincode force-pushed the splincode/feat/optimize branch from 5c6f131 to c1b1610 Feb 25, 2022
@splincode
Copy link
Member Author

@splincode splincode commented Feb 25, 2022

@vladimirpotekhin @nsbarsukov hello, please review me

@splincode splincode merged commit 3884212 into main Feb 25, 2022
11 checks passed
@splincode splincode deleted the splincode/feat/optimize branch Feb 25, 2022
@well-done-bot
Copy link

@well-done-bot well-done-bot bot commented Feb 25, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants