Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use strict properties in tsconfig #1386

Merged
merged 1 commit into from Feb 18, 2022
Merged

ci: use strict properties in tsconfig #1386

merged 1 commit into from Feb 18, 2022

Conversation

splincode
Copy link
Member

@splincode splincode commented Feb 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

@lumberjack-bot
Copy link

@lumberjack-bot lumberjack-bot bot commented Feb 14, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 14, 2022

Visit the preview URL for this PR (updated for commit fd3960c):

https://taiga-ui--pr1386-splincode-ci-tsconfi-yhb7dfco.web.app

(expires Sat, 19 Feb 2022 14:25:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

@codecov codecov bot commented Feb 14, 2022

Codecov Report

Merging #1386 (fd3960c) into main (676dc90) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1386   +/-   ##
=======================================
  Coverage   64.78%   64.79%           
=======================================
  Files         786      786           
  Lines        8824     8828    +4     
  Branches     1745     1745           
=======================================
+ Hits         5717     5720    +3     
  Misses       2687     2687           
- Partials      420      421    +1     
Flag Coverage Δ
addon-charts 71.98% <ø> (ø)
addon-doc 25.84% <ø> (ø)
addon-editor 46.05% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 82.83% <ø> (+0.06%) ⬆️
core 68.94% <ø> (ø)
kit 63.71% <50.00%> (-0.03%) ⬇️
summary 64.79% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../kit/components/multi-select/hide-selected.pipe.ts 72.72% <50.00%> (-9.10%) ⬇️
projects/cdk/observables/drag-and-drop-from.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676dc90...fd3960c. Read the comment docs.

tsconfig.json Outdated Show resolved Hide resolved
@splincode splincode force-pushed the splincode/ci/tsconfig branch 2 times, most recently from a9574f5 to c54dcfb Feb 14, 2022
@splincode splincode requested a review from waterplea Feb 14, 2022
@splincode splincode force-pushed the splincode/ci/tsconfig branch from c54dcfb to d5277c1 Feb 14, 2022
@splincode splincode marked this pull request as draft Feb 16, 2022
@splincode splincode changed the title ci: use strict properties in tsconfig [WIP] ci: use strict properties in tsconfig Feb 16, 2022
@splincode splincode force-pushed the splincode/ci/tsconfig branch 2 times, most recently from d6fdad2 to fc59f67 Feb 18, 2022
@tinkoff-bot tinkoff-bot force-pushed the splincode/ci/tsconfig branch from fc59f67 to 8889073 Feb 18, 2022
@splincode splincode changed the title [WIP] ci: use strict properties in tsconfig ci: use strict properties in tsconfig Feb 18, 2022
@splincode splincode marked this pull request as ready for review Feb 18, 2022
@splincode splincode force-pushed the splincode/ci/tsconfig branch from 8889073 to 789e058 Feb 18, 2022
@splincode splincode force-pushed the splincode/ci/tsconfig branch from 789e058 to fd3960c Feb 18, 2022
@splincode splincode merged commit cd2c728 into main Feb 18, 2022
8 checks passed
@splincode splincode deleted the splincode/ci/tsconfig branch Feb 18, 2022
@well-done-bot
Copy link

@well-done-bot well-done-bot bot commented Feb 18, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants