-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 4 instances of 'gutenberg' text domain from WordPress core #37229
Remove 4 instances of 'gutenberg' text domain from WordPress core #37229
Conversation
Use sprintf() to combine the string with the $label.
Use sprintf() to combine the string with the $label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, @kebbet.
Changes look good, I just left a small comment, but it's not a blocker.
Thanks for feedback!
Thanks for feedback!
Hi, @ocean90 Can we merge this PR? |
All comments were addressed. I reviewed the commit and it looks good, fixing the issue at hand. No failing tests, so I went ahead and merged it 👍 |
…7229) * Remove text domain, set string once. Use sprintf() to combine the string with the $label. * Remove text domain, set string once. Use sprintf() to combine the string with the $label. * Update variable name and translator text. Thanks for feedback! * Update variable name and translator comment. Thanks for feedback!
Closes #37228
Description
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).