Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditions for video showcase #415

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Add conditions for video showcase #415

merged 3 commits into from
Dec 16, 2021

Conversation

laras126
Copy link
Contributor

@laras126 laras126 commented Dec 15, 2021

Add conditions so this does not cause a fatal error if some data is not available or used.

Doneness Checklist:

Pre-release # (or n/a):

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • Ran the visual regression tests manually (see the README for details)
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

@vercel
Copy link

vercel bot commented Dec 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/penske-media-corp/pmc-larva/dTT3C2bx2yD26XC8872Ay2eY18Dk
✅ Preview: https://pmc-larva-git-feature-hub-fixes-penske-media-corp.vercel.app

@laras126 laras126 merged commit fb9faf7 into master Dec 16, 2021
@laras126 laras126 deleted the feature/hub-fixes branch December 16, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants