Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs issue template #32488

Merged
merged 11 commits into from Dec 15, 2021
Merged

Conversation

molebox
Copy link
Contributor

@molebox molebox commented Dec 14, 2021

This PR adds an issue template for docs updates or improvement requests

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@molebox molebox requested a review from styfle December 15, 2021 09:53
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Dec 15, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
buildDuration 17.9s 18s ⚠️ +99ms
buildDurationCached 3.3s 3.4s ⚠️ +109ms
nodeModulesSize 350 MB 350 MB -8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
/ failed reqs 0 0
/ total time (seconds) 2.844 2.848 0
/ avg req/sec 878.96 877.66 ⚠️ -1.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.284 1.298 ⚠️ +0.01
/error-in-render avg req/sec 1946.85 1925.96 ⚠️ -20.89
Client Bundles (main, webpack, commons)
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 30.2 kB 30.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
buildDuration 19.7s 19.5s -191ms
buildDurationCached 3.4s 3.4s -71ms
nodeModulesSize 350 MB 350 MB -8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
/ failed reqs 0 0
/ total time (seconds) 2.919 2.974 ⚠️ +0.06
/ avg req/sec 856.53 840.65 ⚠️ -15.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.302 1.344 ⚠️ +0.04
/error-in-render avg req/sec 1920.47 1860.26 ⚠️ -60.21
Client Bundles (main, webpack, commons)
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 30.3 kB 30.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 74.3 kB 74.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary molebox/next.js docs-issue-template-nextjs Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 0d09206

@timneutkens timneutkens merged commit dda0afd into vercel:canary Dec 15, 2021
39 of 42 checks passed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js docs team PRs by the Next.js docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants