Display block anchor in List View when set. #31992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Feature] Blocks
jasmussen
reviewed
May 19, 2021
| border-radius: 2px; | ||
| display: inline-block; | ||
| padding: 2px 6px; | ||
| margin: 0 8px; |
There was a problem hiding this comment.
8px can be $grid-unit-10
jasmussen
reviewed
May 19, 2021
|
|
||
| .block-editor-block-navigation-block-select-button__anchor { | ||
| background: rgba(30, 30, 30, 0.1); | ||
| border-radius: 2px; |
There was a problem hiding this comment.
This can be $radius-block-ui
jasmussen
reviewed
May 19, 2021
| } | ||
|
|
||
| &.is-selected .block-editor-block-navigation-block-select-button__anchor { | ||
| background: rgba(30, 30, 30, 0.3); |
There was a problem hiding this comment.
This can be rgba( $black, 0.3 )
jasmussen
approved these changes
May 19, 2021
mtias
force-pushed
the
add/show-anchor-in-list-view
branch
from
6b7b32f
to
802ae2e
Compare
jasmussen
reviewed
May 19, 2021
| @@ -243,6 +243,18 @@ | |||
| color: $white; | |||
| } | |||
| } | |||
|
|
|||
| .block-editor-block-navigation-block-select-button__anchor { | |||
| background: rgba(30, 30, 30, 0.1); | |||
There was a problem hiding this comment.
I hate to bug you again, but this could also be rgba( $black, 0.1 ) 🙈
There was a problem hiding this comment.
I went ahead and pushed a fix.
youknowriad
approved these changes
May 19, 2021
|
Truncating long slugs, leaving room for when we add the extra tools on the right:
It might be tricky paired with long block names. |
|
It feels like the panel should have a max-width and not grow as the item grows. |
|
In the future it might be nice to consider allowing the anchor to focus the advanced input in the sidebar. |
This is an existing issue, I just tested:
So we can still land this, but it would be good to polish this further. Specifically we can show the block name, a tool on the right, and then through both truncation, max-widths and making the tool be an overlay, ensure that the block name and tool are at least always visible. Shouldn't block this PR, I think. |
|
Size Change: +141 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
mtias
force-pushed
the
add/show-anchor-in-list-view
branch
from
a29da9e
to
39945ef
Compare
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16307.
See #16296.
When an anchor is set on a block this displays it on the List View. It should help both naming blocks and identifying an important aspect of the site structure. (We should probably truncate long names.)
Video: https://user-images.githubusercontent.com/548849/118816212-3bafd280-b8b2-11eb-9fb7-31d942d606bf.mov