Post editor: fix wrapper block name for template mode #31985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
force-pushed
the
try/template-mode-no-recursion-provider
branch
from
8aa26f5
to
71bec7f
Compare
youknowriad
added
[Feature] Full Site Editing
[Type] Bug
ellatrix
force-pushed
the
try/template-mode-no-recursion-provider
branch
from
71bec7f
to
48c58c2
Compare
ellatrix
changed the title
ellatrix
force-pushed
the
try/template-mode-no-recursion-provider
branch
from
48c58c2
to
baefc18
Compare
|
Size Change: +16 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/template-mode-no-recursion-provider
branch
from
baefc18
to
d2310c3
Compare
mcsf
approved these changes
May 19, 2021
There was a problem hiding this comment.
Thanks, this fixes the issue. 👍 I also tested editing templates, template parts, and reusable blocks, to ensure that those aren't affected (i.e., loops are prevented, but nothing else).
It's clear that injecting context in VisualEditor is not ideal: it's hard to debug and it couples the loop-preventing hook with a particular component. @gziolo and I discussed some possibilities for the near future, including removing any magic from VisualEditor and, at worst, move it into useNoRecursiveRenders.
|
Thank you for this fix. This functionality needs more work to account for other blocks like the Template Part one. Let's keep it on the radar during 5.8 cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31869
Props to @ntsekouras for finding the problematic line. :)