Use new core functions in menu items REST API #35648
Open
+19
−22
Conversation
Mamaduka
reviewed
Oct 15, 2021
| if ( ! empty( $menu_item->object_id ) ) { | ||
| if ( 'post_type' === $menu_item->type ) { | ||
| $path = rest_get_route_for_post( $menu_item->object_id ); | ||
| if ( $path ) { | ||
| $links['https://api.w.org/object'][] = array( | ||
| 'href' => rest_url( $path ), | ||
| 'post_type' => $menu_item->type, | ||
| 'embeddable' => true, | ||
| ); | ||
| } | ||
| } elseif ( 'taxonomy' === $menu_item->type ) { | ||
| $path = rest_get_route_for_term( $menu_item->object_id ); | ||
| if ( $path ) { | ||
| $links['https://api.w.org/object'][] = array( | ||
| 'href' => rest_url( $path ), | ||
| 'taxonomy' => $menu_item->type, | ||
| 'embeddable' => true, | ||
| ); | ||
| } |
Maybe we could return early here, and I think we can also split type checks into two if statements.
It's just a personal nitpick. I find nested if statements hard to ready. Feel free to ignore.
Something like this:
if ( empty( $menu_item->object_id ) ) {
return $links;
}
if ( 'post_type' === $menu_item->type ) {
$path = rest_get_route_for_post( $menu_item->object_id );
if ( $path ) {
$links['https://api.w.org/object'][] = array(
'href' => rest_url( $path ),
'post_type' => $menu_item->type,
'embeddable' => true,
);
}
}
if ( 'taxonomy' === $menu_item->type ) {
$path = rest_get_route_for_term( $menu_item->object_id );
if ( $path ) {
$links['https://api.w.org/object'][] = array(
'href' => rest_url( $path ),
'taxonomy' => $menu_item->type,
'embeddable' => true,
);
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
In the menu item controller, use the new functions rest_get_route_for_term and rest_get_route_for_post. These functions are not part of core at time of writing on the REST API menu item endpoints and were added in WP 5.5.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).The text was updated successfully, but these errors were encountered: