Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown highlighting on components CONTRIBUTING.md #35633

Merged
merged 2 commits into from Oct 14, 2021

Conversation

diegohaz
Copy link
Member

This PR fixes the markdown highlighting in the CONTRIBUTING.md file in the @wordpress/components package.

Before

image

After

image

@diegohaz diegohaz added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Oct 14, 2021
@diegohaz diegohaz self-assigned this Oct 14, 2021
@diegohaz diegohaz requested review from mirka and ciampo October 14, 2021 12:05
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Thank you for the fix 🚀

@@ -349,6 +349,7 @@ Add this section when there are props that are drilled down into an internal com
## Context

See examples for this section for the [ItemGroup](/packages/components/src/item-group/item-group/README.md#context) and [`Card`](/packages/components/src/card/card/README.md#context) components.
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduced this regression in #35620, thank you for catching it so quickly!

@diegohaz diegohaz merged commit 2d79bb9 into trunk Oct 14, 2021
@diegohaz diegohaz deleted the docs/components-contributing-markdown-highlighting branch October 14, 2021 12:49
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants