Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SotW visual polish and test for global footer #101

Closed
3 tasks
Tracked by #83
tellyworth opened this issue Dec 2, 2021 · 9 comments
Closed
3 tasks
Tracked by #83

SotW visual polish and test for global footer #101

tellyworth opened this issue Dec 2, 2021 · 9 comments
Labels
Good First Issue Good for newcomers Help Wanted Extra attention is needed

Comments

@tellyworth
Copy link
Contributor

The global footer (about links etc) needs to look correct for the SotW demo. At a quick glance it seems ok, but could use some careful testing and review. Here's a recent screenshot from the test site:
Screen Shot 2021-12-02 at 4 06 31 pm

What we need is:

  • Check the footer on the test site against figma for any visual problems
  • Also check for responsiveness etc, across different page types
  • Discuss here and open issues for anything that must be fixed for SotW and include it in the milestone.
@tellyworth tellyworth added Good First Issue Good for newcomers Help Wanted Extra attention is needed labels Dec 2, 2021
@tellyworth tellyworth added this to the State of the Word preview milestone Dec 2, 2021
@tellyworth tellyworth mentioned this issue Dec 2, 2021
20 tasks
@danieldudzic
Copy link
Collaborator

danieldudzic commented Dec 2, 2021

I have compared the test site against the Figma file and noticed:

  • The font-size for the global footer links on the test site is set to 16px, the Figma has it set to 13px

@tellyworth
Copy link
Contributor Author

The font size should be fixed now, 13px as per the Figma.

Are there other issues with the footer or can we close this?

tellyworth added a commit to WordPress/wporg-mu-plugins that referenced this issue Dec 6, 2021
@scruffian
Copy link
Collaborator

This looks good to me. The only difference I can see with Figma is a few extra links. This is the figma file:
Screenshot 2021-12-07 at 17 45 42

The additional links make the footer appear slightly unbalanced, should we remove them? cc @beafialho

@beafialho
Copy link
Collaborator

Yes, we can remove those additional links

@scruffian
Copy link
Collaborator

Done in WordPress/wporg-mu-plugins#27

@ryelle
Copy link
Contributor

ryelle commented Dec 8, 2021

I think this issue can be closed out now that the links are removed?

@scruffian
Copy link
Collaborator

The only remaining issue I see is that the bottom gap between the links and the WordPress logo is slightly off.

@mikachan
Copy link
Member

mikachan commented Dec 9, 2021

Opened a PR for the gap between the links and the WordPress logo: WordPress/wporg-mu-plugins#31

@scruffian
Copy link
Collaborator

I think this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants