-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SotW visual polish and test for global footer #101
Comments
I have compared the test site against the Figma file and noticed:
|
The font size should be fixed now, 13px as per the Figma. Are there other issues with the footer or can we close this? |
This looks good to me. The only difference I can see with Figma is a few extra links. This is the figma file: The additional links make the footer appear slightly unbalanced, should we remove them? cc @beafialho |
Yes, we can remove those additional links |
Done in WordPress/wporg-mu-plugins#27 |
I think this issue can be closed out now that the links are removed? |
The only remaining issue I see is that the bottom gap between the links and the WordPress logo is slightly off. |
Opened a PR for the gap between the links and the WordPress logo: WordPress/wporg-mu-plugins#31 |
I think this can be closed now. |
The global footer (about links etc) needs to look correct for the SotW demo. At a quick glance it seems ok, but could use some careful testing and review. Here's a recent screenshot from the test site:
![Screen Shot 2021-12-02 at 4 06 31 pm](https://webcf.waybackmachine.org/web/20240712193746im_/https://user-images.githubusercontent.com/7200686/144361344-9ff094f3-04eb-4234-8c10-2003fa0eb2b4.png)
What we need is:
The text was updated successfully, but these errors were encountered: