ColorPicker: Replace hardcoded "blue" with theme color #36153
Conversation
Code-wise, the changes LGTM!
The highlighted text in the color picker follows the selected theme:
color-picker-theme-color.mp4
Before merging, though, I'd like to get a blessing from @jasmussen too (thank you, Joen!)
Code looks good, thank you! Definitely use the theme color for this in similar cases as well. I do suspect some time in the future, we'll want to revisit some of those color schemes for contrast and such, but that's entirely separate.
Note that I wasn't actually able to test this, I got an error:
But I'm almost convinced that error was present in trunk at the time (14 days ago), and will be fixed if the PR is rebased.
Thank you for your review @jasmussen ! I mainly wanted to make sure that it's fine to use the admin theme color in this scenario :)
Note that I wasn't actually able to test this, I got an error:
I don't think this PR could have introduced this error, since it's a very simple JS (CSS) change. FWIW, I carried my tests via this link
|
Yep, I recall those errors happening to unrelated branches. This looks good. |
* ColorPicker: Replace hardcoded "blue" with theme color * Update changelog
Description
ColorPickerused a hardcodedbluecolor for its input prefixes, which can look quite random when users have different admin theme colors set. This PR replaces the hardcoded color with the UI theme color.How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).The text was updated successfully, but these errors were encountered: