Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the format used for duplicate hook docs #32563

Merged
merged 1 commit into from Jun 11, 2021

Conversation

@johnbillion
Copy link
Member

@johnbillion johnbillion commented Jun 9, 2021

Description

This fixes the format used for a duplicate hook doc.

This should use a block-level comment instead of an inline comment. The inline comment format causes WP Parser to see the hook as undocumented.

How has this been tested?

I confirmed that WP Parser Lib no longer treats this as an undocumented hook.

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
lib/edit-site-page.php Outdated Show resolved Hide resolved
Copy link
Member

@gziolo gziolo left a comment

This PR needs a rebase. It would be great to land the change for Latest Comments block 👍🏻

The other comment was probably fixed and moved to another place.

@gziolo
gziolo approved these changes Jun 11, 2021
Copy link
Member

@gziolo gziolo left a comment

Thank you, let's merge when CI turns green.

@gziolo gziolo merged commit 289b13c into WordPress:trunk Jun 11, 2021
17 checks passed
17 checks passed
@github-actions
Bump version
Details
@github-actions
Checks (12)
Details
@github-actions
Admin - 1 Admin - 1
Details
@github-actions
Run performance tests
Details
@github-actions
test (gutenberg-editor-initial-html, 14)
Details
@github-actions
test (12.2, gutenberg-editor-initial-html, 14)
Details
@github-actions
JavaScript (12)
Details
@github-actions
Checks (14)
Details
@github-actions
Admin - 2 Admin - 2
Details
@github-actions
JavaScript (14)
Details
@github-actions
Admin - 3 Admin - 3
Details
@github-actions
Admin - 4 Admin - 4
Details
@github-actions
Build Release Artifact
Details
@github-actions
Create Release Draft and Attach Asset
Details
@github-actions
Mobile
Details
@github-actions github-actions bot added this to the Gutenberg 10.9 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants