Correct the format used for duplicate hook docs #32563
Merged
Conversation
johnbillion
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as
code owners
Jun 9, 2021
This PR needs a rebase. It would be great to land the change for Latest Comments block 👍🏻 The other comment was probably fixed and moved to another place. |
johnbillion
force-pushed the
johnbillion:duplicate-hook-docs
branch
from
Jun 11, 2021
c008cd2
to
2d9e453
Thank you, let's merge when CI turns green. |
vcanales
added a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
johnbillion commentedJun 9, 2021
•
edited
Description
This fixes the format used for a duplicate hook doc.
This should use a block-level comment instead of an inline comment. The inline comment format causes WP Parser to see the hook as undocumented.
How has this been tested?
I confirmed that WP Parser Lib no longer treats this as an undocumented hook.
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).