Unhide the classic menu widget #32431
Merged
Conversation
draganescu
changed the title
use the classic menu widget again
Unhide the classic menu widget
Jun 3, 2021
draganescu
added this to PRs needing review
in Block-based Widgets Editor
via automation
Jun 3, 2021
This looks good to merge but note it only fixes WordPress 5.7 running the Gutenberg plugin (and therefore doesn't need to be backported.) |
vcanales
added a commit
that referenced
this pull request
Jul 7, 2021
Co-authored-by: Andrei Draganescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
draganescu commentedJun 3, 2021
•
edited
Description
According to the Track ticket 53301
All the classic widgets have been replaced by blocks and hence the decision to hide them from being used makes sense. However the "Navigation Menu" widget is not fully replaced by the
Navigation
because theNavigation
block is currently missing the ability to update itself if a classic menu has been changed. TheNavigation
block can only import a classic menu, creating a static copy of it. This behavior is different and unexpected in the widgets context.While the
LegacyWidget
block does display the "Navigation Menu" widget, adding new ones is not possible without this change. It should be possible, considering we don't even have a transform yet from the "Navigation Menu" widget to theNavigatioin
block, liike all the other core classic widgets do.How has this been tested?
Screenshots
Types of changes
Removed the
nav_menu
widget from thewidget_types_to_hide_from_legacy_widget_block
filter.Also fixed a typo in a comment.