Skip to content

/ gutenberg Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Letter spacing should also respect skip serialization flag #32459

Merged
merged 1 commit into from Jun 4, 2021
Merged

Letter spacing should also respect skip serialization flag #32459

merged 1 commit into from Jun 4, 2021

Conversation

@oandregal
Copy link
Member

@oandregal oandregal commented Jun 4, 2021

Follow-up to #32444

Makes letter spacing block supports respect the skip serialization flag, see.
@oandregal
Letter spacing should also respect skip serialization
af87560
@oandregal oandregal requested a review from jorgefilipecosta Jun 4, 2021
@oandregal oandregal self-assigned this Jun 4, 2021
@oandregal oandregal mentioned this pull request Jun 4, 2021
Merged
@oandregal oandregal changed the title Letter spacing should also respect skip serialization Letter spacing should also respect skip serialization flag Jun 4, 2021
@oandregal oandregal added this to the Gutenberg 10.8 milestone Jun 4, 2021
@oandregal
Copy link
Member Author

@oandregal oandregal commented Jun 4, 2021

As with #32444, this needs to be in 10.8.

jorgefilipecosta
jorgefilipecosta approved these changes Jun 4, 2021
View changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit e9f0983 into trunk Jun 4, 2021
19 checks passed
19 checks passed
@github-actions[bot]
Bump version
Details
@github-actions[bot]
Checks (12)
Details
@github-actions[bot]
Admin - 1 Admin - 1
Details
@github-actions[bot]
Run performance tests
Details
@github-actions[bot]
pull-request-automation
Details
@github-actions[bot]
pull-request-automation
Details
@github-actions[bot]
test (gutenberg-editor-initial-html)
Details
@github-actions[bot]
test (12.2, gutenberg-editor-initial-html)
Details
@github-actions[bot]
All
Details
@github-actions[bot]
JavaScript (12)
Details
@github-actions[bot]
Checks (14)
Details
@github-actions[bot]
Admin - 2 Admin - 2
Details
@github-actions[bot]
JavaScript (14)
Details
@github-actions[bot]
Admin - 3 Admin - 3
Details
@github-actions[bot]
Admin - 4 Admin - 4
Details
@github-actions[bot]
Build Release Artifact
Details
@github-actions[bot]
PHP
Details
@github-actions[bot]
Create Release Draft and Attach Asset
Details
@github-actions[bot]
Mobile
Details
@jorgefilipecosta jorgefilipecosta deleted the fix/letter-spacing-skip-serialization branch Jun 4, 2021
youknowriad added a commit that referenced this issue Jun 7, 2021
@nosolosw @youknowriad
Letter spacing should also respect skip serialization flag (#32459)
09339db
@youknowriad youknowriad mentioned this pull request Jun 7, 2021
Merged
youknowriad added a commit that referenced this issue Jun 7, 2021
@nosolosw @youknowriad
Letter spacing should also respect skip serialization flag (#32459)
1c1c969
youknowriad added a commit to youknowriad/wordpress-develop that referenced this issue Jun 7, 2021
@youknowriad
Port a few PRs
95770ec 
WordPress/gutenberg#32252
WordPress/gutenberg#32444
WordPress/gutenberg#32459

props jorgefilipecosta nosolosw
pento pushed a commit to WordPress/wordpress-develop that referenced this issue Jun 8, 2021
@youknowriad @youknowriad
Block Editor: Package updates for 5.8 beta 1.
377c88d 
This includes the following fixes:


Widgets Editor:
  - Load widgets.php WordPress/gutenberg#32299
 - Fix Legacy Widget Preview WordPress/gutenberg#32300
 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359

Widget blocks in the customizer: 
 - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361
 - Display wide widgets as popovers WordPress/gutenberg#31736

Global Styles:
 - Align classNames generation between client and server WordPress/gutenberg#32352
 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459
 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404


Template Editor:
  - Update the appearance of the template details WordPress/gutenberg#32042
  - Fix layout definition WordPress/gutenberg#32425
  - Fix grouping post content block WordPress/gutenberg#32453

Miscellaneous:
 - Prevent saving when the post is locked WordPress/gutenberg#32341
 - Fix allowed block patterns selector WordPress/gutenberg#32376
 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344
 - Fix notices position in top toolbar mode WordPress/gutenberg#32238
 - Allow non-latin characters in post slugs WordPress/gutenberg#32232
 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388
 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370
 - Fix block alignment styles in the editor WordPress/gutenberg#32454
 - Fix some block toolbar overlaps WordPress/gutenberg#32424
 - Fix content loss when switching list types WordPress/gutenberg#32432


Performance:
 - Improve the performance of buttons block WordPress/gutenberg#32356
 - Improve the performance of the container blocks WordPress/gutenberg#32380

Props noisysocks, nosolosw, jorgefilipecosta.
See #52991.


git-svn-id: https://develop.svn.wordpress.org/trunk@51089 602fd350-edb4-49c9-b593-d223f7449a82
nylen pushed a commit to nylen/wordpress-develop-svn that referenced this issue Jun 8, 2021
Block Editor: Package updates for 5.8 beta 1.
f4b811c 
This includes the following fixes:


Widgets Editor:
  - Load widgets.php WordPress/gutenberg#32299
 - Fix Legacy Widget Preview WordPress/gutenberg#32300
 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359

Widget blocks in the customizer: 
 - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361
 - Display wide widgets as popovers WordPress/gutenberg#31736

Global Styles:
 - Align classNames generation between client and server WordPress/gutenberg#32352
 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459
 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404


Template Editor:
  - Update the appearance of the template details WordPress/gutenberg#32042
  - Fix layout definition WordPress/gutenberg#32425
  - Fix grouping post content block WordPress/gutenberg#32453

Miscellaneous:
 - Prevent saving when the post is locked WordPress/gutenberg#32341
 - Fix allowed block patterns selector WordPress/gutenberg#32376
 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344
 - Fix notices position in top toolbar mode WordPress/gutenberg#32238
 - Allow non-latin characters in post slugs WordPress/gutenberg#32232
 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388
 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370
 - Fix block alignment styles in the editor WordPress/gutenberg#32454
 - Fix some block toolbar overlaps WordPress/gutenberg#32424
 - Fix content loss when switching list types WordPress/gutenberg#32432


Performance:
 - Improve the performance of buttons block WordPress/gutenberg#32356
 - Improve the performance of the container blocks WordPress/gutenberg#32380

Props noisysocks, nosolosw, jorgefilipecosta.
See #52991.


git-svn-id: https://develop.svn.wordpress.org/trunk@51089 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this issue Jun 8, 2021
@youknowriad @youknowriad
Block Editor: Package updates for 5.8 beta 1.
1516d05 
This includes the following fixes:


Widgets Editor:
  - Load widgets.php WordPress/gutenberg#32299
 - Fix Legacy Widget Preview WordPress/gutenberg#32300
 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359

Widget blocks in the customizer: 
 - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361
 - Display wide widgets as popovers WordPress/gutenberg#31736

Global Styles:
 - Align classNames generation between client and server WordPress/gutenberg#32352
 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459
 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404


Template Editor:
  - Update the appearance of the template details WordPress/gutenberg#32042
  - Fix layout definition WordPress/gutenberg#32425
  - Fix grouping post content block WordPress/gutenberg#32453

Miscellaneous:
 - Prevent saving when the post is locked WordPress/gutenberg#32341
 - Fix allowed block patterns selector WordPress/gutenberg#32376
 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344
 - Fix notices position in top toolbar mode WordPress/gutenberg#32238
 - Allow non-latin characters in post slugs WordPress/gutenberg#32232
 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388
 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370
 - Fix block alignment styles in the editor WordPress/gutenberg#32454
 - Fix some block toolbar overlaps WordPress/gutenberg#32424
 - Fix content loss when switching list types WordPress/gutenberg#32432


Performance:
 - Improve the performance of buttons block WordPress/gutenberg#32356
 - Improve the performance of the container blocks WordPress/gutenberg#32380

Props noisysocks, nosolosw, jorgefilipecosta.
See #52991.

Built from https://develop.svn.wordpress.org/trunk@51089


git-svn-id: http://core.svn.wordpress.org/trunk@50698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this issue Jun 8, 2021
@youknowriad @youknowriad
Block Editor: Package updates for 5.8 beta 1.
b914570 
This includes the following fixes:


Widgets Editor:
  - Load widgets.php WordPress/gutenberg#32299
 - Fix Legacy Widget Preview WordPress/gutenberg#32300
 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359

Widget blocks in the customizer: 
 - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361
 - Display wide widgets as popovers WordPress/gutenberg#31736

Global Styles:
 - Align classNames generation between client and server WordPress/gutenberg#32352
 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459
 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404


Template Editor:
  - Update the appearance of the template details WordPress/gutenberg#32042
  - Fix layout definition WordPress/gutenberg#32425
  - Fix grouping post content block WordPress/gutenberg#32453

Miscellaneous:
 - Prevent saving when the post is locked WordPress/gutenberg#32341
 - Fix allowed block patterns selector WordPress/gutenberg#32376
 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344
 - Fix notices position in top toolbar mode WordPress/gutenberg#32238
 - Allow non-latin characters in post slugs WordPress/gutenberg#32232
 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388
 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370
 - Fix block alignment styles in the editor WordPress/gutenberg#32454
 - Fix some block toolbar overlaps WordPress/gutenberg#32424
 - Fix content loss when switching list types WordPress/gutenberg#32432


Performance:
 - Improve the performance of buttons block WordPress/gutenberg#32356
 - Improve the performance of the container blocks WordPress/gutenberg#32380

Props noisysocks, nosolosw, jorgefilipecosta.
See #52991.

Built from https://develop.svn.wordpress.org/trunk@51089


git-svn-id: https://core.svn.wordpress.org/trunk@50698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jun 9, 2021

Cherry-picked into 10.8 release branch.

youknowriad added a commit that referenced this issue Jun 9, 2021
@nosolosw @youknowriad
Letter spacing should also respect skip serialization flag (#32459)
06486a3
vcanales added a commit that referenced this issue Jul 7, 2021
@nosolosw @vcanales
Letter spacing should also respect skip serialization flag (#32459)
f994e03
F-Wilke added a commit to FiliagoDev/WordPress that referenced this issue Jul 31, 2021
@youknowriad @youknowriad @F-Wilke
Block Editor: Package updates for 5.8 beta 1.
86696e1 
This includes the following fixes:


Widgets Editor:
  - Load widgets.php WordPress/gutenberg#32299
 - Fix Legacy Widget Preview WordPress/gutenberg#32300
 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359

Widget blocks in the customizer: 
 - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361
 - Display wide widgets as popovers WordPress/gutenberg#31736

Global Styles:
 - Align classNames generation between client and server WordPress/gutenberg#32352
 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459
 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404


Template Editor:
  - Update the appearance of the template details WordPress/gutenberg#32042
  - Fix layout definition WordPress/gutenberg#32425
  - Fix grouping post content block WordPress/gutenberg#32453

Miscellaneous:
 - Prevent saving when the post is locked WordPress/gutenberg#32341
 - Fix allowed block patterns selector WordPress/gutenberg#32376
 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344
 - Fix notices position in top toolbar mode WordPress/gutenberg#32238
 - Allow non-latin characters in post slugs WordPress/gutenberg#32232
 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388
 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370
 - Fix block alignment styles in the editor WordPress/gutenberg#32454
 - Fix some block toolbar overlaps WordPress/gutenberg#32424
 - Fix content loss when switching list types WordPress/gutenberg#32432


Performance:
 - Improve the performance of buttons block WordPress/gutenberg#32356
 - Improve the performance of the container blocks WordPress/gutenberg#32380

Props noisysocks, nosolosw, jorgefilipecosta.
See #52991.

Built from https://develop.svn.wordpress.org/trunk@51089


git-svn-id: http://core.svn.wordpress.org/trunk@50698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta

@spacedmonkey spacedmonkey

@TimothyBJacobs TimothyBJacobs

Assignees

@oandregal oandregal

Labels
Global Styles [Type] Bug
Projects
None yet
Milestone
Gutenberg 10.8
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@oandregal @youknowriad @jorgefilipecosta