Remove redundant widget API endpoint tests #32298
Merged
Conversation
noisysocks
added this to PRs needing review
in Block-based Widgets Editor
via automation
talldan
approved these changes
May 28, 2021
LGTM
![@github-actions[bot]](https://webcf.waybackmachine.org/web/20210916170929im_/https://avatars.githubusercontent.com/in/15368?v=4){kind=small}
noisysocks
added a commit
that referenced
this issue
Jun 8, 2021
|
Cherry-picked this into |
vcanales
added a commit
that referenced
this issue
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Removes the Widgets REST API unit tests from the Gutenberg plugin.
These are redundant as these endpoints and their tests now exist in Core.
https://github.com/WordPress/wordpress-develop/blob/master/tests/phpunit/tests/rest-api/rest-widgets-controller.php
https://github.com/WordPress/wordpress-develop/blob/master/tests/phpunit/tests/rest-api/rest-widget-types-controller.php
https://github.com/WordPress/wordpress-develop/blob/master/tests/phpunit/tests/rest-api/rest-sidebars-controller.php
If we attempt to run them in the Gutenberg plugin then we will have failures because we always run Gutenberg CI against the latest WordPress
trunkmeaning the REST API endpoints will be registered twice (once in core, once again in the plugin).The text was updated successfully, but these errors were encountered: