Performance Tests Workflow: Use latest WP branch for release tests #32277
Conversation
mcsf
approved these changes
May 27, 2021
Let's give it a go.
youknowriad
reviewed
May 28, 2021
| @@ -56,4 +56,4 @@ jobs: | |||
| WP_VERSION=$(grep -oP "$TESTED_UP_TO_REGEX" ./readme.txt) | |||
| IFS='.' read -r -a WP_VERSION_ARRAY <<< "$WP_VERSION" | |||
| WP_BRANCH="wp/${WP_VERSION_ARRAY[0]}.${WP_VERSION_ARRAY[1]}" | |||
| ./bin/plugin/cli.js perf --ci $WP_BRANCH $PREVIOUS_RELEASE_BRANCH $CURRENT_RELEASE_BRANCH | |||
| ./bin/plugin/cli.js perf --ci $WP_BRANCH $PREVIOUS_RELEASE_BRANCH $CURRENT_RELEASE_BRANCH --tests-branch $WP_BRANCH | |||
I think I disagree with this one :) That's not what I suggested, I think we should always use "trunk" for the performance tests themselves, the issue is with the base branch used in the docker container which means we'll get a recent WP install (trunk) with all the new APIs with an old Gutenberg plugin wp/5.7 branch causing conflicts. I think @mcsf's PR solves that.
7 tasks
vcanales
added a commit
that referenced
this issue
Jul 7, 2021
…32277) As Riad mentioned in Slack: > [R]elease perf jobs are breaking https://github.com/WordPress/gutenberg/runs/2676154517?check_suite_focus=true. If I have to guess, I think it's because the base WP install used comes from trunk and the fixes for the conflicts introduced so solve the conflicts are not included in both the previous release's branch and `wp/5.7` branch. Ideal fix would be to rely on the `5.7` (previous wp release) as base branch instead of latest trunk like all the e2e tests jobs. Turns out the performance script has a `--tests-branch` arg that is already used to set the branch from which we run the WP env for those tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Supersedes #32244.
As @youknowriad mentioned in Slack:
Turns out the performance script has a
--tests-brancharg that is already used to set the branch from which we run the WP env for those tests:gutenberg/.github/workflows/performance.yml
Line 44 in 45e1997
It's used at
gutenberg/bin/plugin/commands/performance.js
Lines 231 to 241 in 45e1997
How has this been tested?
We'll only really know once we release the next GB version.
The text was updated successfully, but these errors were encountered: