Size Change: -568 B (0%)

Total Size: 1.86 MB

_{compressed-size-action}

What I like about this solution though is that it seems to make left/right alignment work well even inside containers with a "content size". Would be cool if we find a way to solve the responsiveness.

Yeah, as Maggie said, this should be responsive since we changed the approach to use grid.

I'm testing with tt1-blocks, I'm not seeing a difference between wide and full alignments after this PR (both show as "wide" I think)

Something else I noticed is that while we were considering enabling "floats" (align left and right) for containers with a layout defined, I didn't manage to make floats work with this approach (grid container), maybe you all know how we could do that?

Something else I noticed is that while we were considering enabling "floats" (align left and right) for containers with a layout defined, I didn't manage to make floats work with this approach (grid container), maybe you all know how we could do that?

there's the option of using justify-self: start/end; for those but that would align them left or right within the borders of the full width container. Let me play a bit with this on more than one theme and see what I can come up with. What do we expect the align left/right to look like?

This is a pretty wild one. At a first glance and on a basic level, this worked for me:

The grid also didn't seem to cascade into other grid containers, so that's good:

The part where it's wild is that by making the container into a grid container, every block inside is placed on grid-auto-rows:

... which also means you could theoretically add a gap: 40px;, like so:

— not that anyone should, because the margins of blocks are still present:

Unfortunately that's also where things started to fall apart for me. The grid prevents margin collapsing:

This can be seen as an opportunity — with all that the grid container offers, we might want to leverage some of the harmonious spacing features that are possible when using gap instead of margins to space things out. Things like first-child/last-child margins are handled more elegantly there, so I definitely think this could be a cool thing. But it's also a bit of a mouthful to have on by default, perhaps?

Riad mentioned floats — those are possible inside groups:

Margins also collapse just fine inside groups, since unless they have layout applied, are not grid containers.

All that is to say — I think there's huge potential here, and that this is likely something we'll want to do. In #16998 similar thoughts are being discussed, around how we can accomplish incredible layouts using something like this, by defining wide and full-wide as grid-column presets that can easily be adjusted, by having ad-hoc resize handles appear in the gutters between blocks.

But I do worry about what the lack of margin collapsing does for existing themes, even if it only affects block themes; it's quite a change since most post-content containers have layout, and suddenly paragraphs have double-margins.

Should we revert this one until we resolve the issue(s) outlined above?

Yes, I think we should revert this one. The "grid" container should be a possibility but I think it makes more sense as its own layout type and not the default one.

PR #32312 reverts this 👍

I think we should reconsider this. Could we add a theme_supports for "inherit layout", so that theme developers are able to opt in to the feature and adjust their themes accordingly?

Alternatively we could look at removing margins of blocks inside "inherit layout" containers.