WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 34 hours ago

#54318 assigned task (blessed)

Import Twenty Twenty-Two

Reported by: jffng Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version: trunk
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The default theme for 2022 should be added to trunk/wp-content/themes in time for the feature freeze on November 9.

Change History (33)

This ticket was mentioned in Slack in #core by jffng. View the logs.


6 weeks ago

#2 @SergeyBiryukov
6 weeks ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from Awaiting Review to 5.9
  • Summary changed from Add the default theme for Twenty Twenty-Two to Import Twenty Twenty-Two
  • Type changed from feature request to task (blessed)

#3 @jffng
6 weeks ago

Since 2022 is a block theme, will the checks for Gutenberg need to be removed? [51193]

If so, should we open a separate ticket for that?

Last edited 6 weeks ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in PR #1817 on WordPress/wordpress-develop by jffng.


5 weeks ago

  • Keywords has-patch added; needs-patch removed

#5 @prbot
4 weeks ago

jffng commented on PR #1817:

In the past discussions and iterations happen on Core merge PRs and are then copied upstream into the theme repository to keep the two in sync. We'll follow the same process here.

Sounds good to me, thank you for the review @desrosj ! I believe the feedback has been addressed, let me know what you think.

#6 @desrosj
4 weeks ago

  • Owner set to desrosj
  • Status changed from new to assigned

#7 @desrosj
4 weeks ago

In 52081:

Bundled Themes: Import Twenty Twenty-Two, the new default theme for WordPress 5.9.

Twenty Twenty-Two arrives during an exciting time for WordPress themes. With the advent of Full Site Editing and Global Styles, themes are changing structurally and functionally to enable far more avenues for customization than users have come to expect in the past.

To take advantage of these new abilities, Twenty Twenty-Two has been designed to be the most flexible default theme ever created for WordPress.

Props sourav926, aristath, audrasjb, bgardner, briceduclos, poena, colorful-tones, dgwyer, dimadin, gregrickaby, ellenbauer, jffng, kafleg, karmatosed, kraftbj, kjellr, littlebigthing, onemaggie, matveb, mburridge, mtoensing, nickcernis, nielslange, williampatton, pgking, ribaricplusplus, scruffian, soean, utz119, youknowriad, desrosj, richtabor.
See #54318.

#8 @desrosj
4 weeks ago

In 52093:

Themes: Twenty Twenty-Two is now the default theme.

It's Friday night, and I feel alright. The party is here in the block theme.

See #54318.

#9 @poena
4 weeks ago

Was the assets folder purposely left out?

#10 @desrosj
4 weeks ago

@poena It was not! I probably missed it because there are some rules that ignore asset directories, and my svn add command skipped it.

This was fixed in [52107] (I had the incorrect ticket number there), and I rebuilt the nightly. So updating to the latest should fix this.

#11 follow-up: @poena
4 weeks ago

With the assets folder included, I am getting the following 404 in the editors and front:

10:01:18.141 localhost/:161 GET http://localhost:8889/wp-content/themes/twentytwentytwo/assets/fonts/SourceSerif4Variable-Roman.ttf.woff2/ net::ERR_ABORTED 404 (Not Found)

#12 in reply to: ↑ 11 @onemaggie
4 weeks ago

Replying to poena:

With the assets folder included, I am getting the following 404 in the editors and front:

10:01:18.141 localhost/:161 GET http://localhost:8889/wp-content/themes/twentytwentytwo/assets/fonts/SourceSerif4Variable-Roman.ttf.woff2/ net::ERR_ABORTED 404 (Not Found)

I'm not getting a 404 on the font using trunk myself (tested on Safari, Chrome and FF)

#13 follow-up: @jffng
4 weeks ago

Same, the fonts are loading without error for me. Thanks for taking care of the import @desrosj.

Since the theme has been imported in [52081] and [52107], does it make sense to close this and address specific issues in follow up tickets?

#15 @jffng
3 weeks ago

In 52164:

Twenty Twenty-Two: Import the latest changes from GitHub.

Updates theme.json to use v2 shape, adds styles to search and file block as well as generic text decoration. Fixes a bug in the layout of a query block pattern.

This is a follow-up to [52081]. These changes are ongoing and development continues on GitHub. To view all of the changes included in this commit, see GitHub: https://github.com/WordPress/twentytwentytwo/compare/99db6063beb87eda7f58c3983992d94cd756d9c2...a11fb4932a0f79dc2668e92f118fd315256be9d9

Props desrosj, kjellr, poena.
See #54318.

#16 in reply to: ↑ 13 @desrosj
3 weeks ago

Since the theme has been imported in [52081] and [52107], does it make sense to close this and address specific issues in follow up tickets?

Whichever works for you and the team's workflows. Having one ongoing task ticket to use for syncing the theme from GitHub until the RC phase is how it's been done the last few default themes. But whenever the theme is at a solid and stable state (or when you prefer), this can be closed out in favor of specific tickets going forward. It's probably good to archive the GH repo at that time, and move all of the open issues over to Trac.

#17 @desrosj
3 weeks ago

  • Owner desrosj deleted

#19 @prbot
3 weeks ago

kjellr commented on PR #1906:

We should be sure to integrate this fix before merge — otherwise the header template errors out:

https://github.com/WordPress/twentytwentytwo/pull/247

#20 @jffng
3 weeks ago

In 52222:

Twenty Twenty-Two: Sync updates from GitHub.

This commit syncs several changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], and [52164]. It includes improvements to the home page template, adding a filter for block patterns, pre-loading the web font, improvements and bug fixes to block patterns, and more. For a full list of changes, visit https://github.com/WordPress/twentytwentytwo/compare/e4f69d0b7ed93f73b33c5991430618d01b0e3cac...25d74deaa57ba49b5a64a8569e6dd9ebadbfb23c.

Props jeffpaul, richtabor, netweb, luminuu, melchoyce, beafealho, clucasrowlands, desrosj, flixos90, joen, otto42, saju4wordpress, westonruter, kjellr, poena.
See #54318.

This ticket was mentioned in Slack in #core-themes by jffng. View the logs.


2 weeks ago

This ticket was mentioned in Slack in #core by jffng. View the logs.


9 days ago

#26 @hellofromTonya
8 days ago

  • Keywords commit added

Marking PR 1970 ready for commit.

#27 @jffng
8 days ago

In 52283:

Twenty Twenty-Two: Sync updates from GitHub.

This commit syncs minor changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], and [52222]. It includes changes to template part markup, theme.json appearance flags, navigation block markup, and text domains. For a full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/742df6cb2b01bedfb9ff54210a7b23765baa0d2f...1a121e0224c75ffa1c34fff4860386e9cdb9e3bd.

Props poena, kjellr, onemaggie, hellofromtonya.
See #54318.

#29 @hellofromTonya
8 days ago

  • Keywords needs-testing has-patch commit removed

Resetting keywords as latest sync updates were committed in [52283].

#32 @jffng
34 hours ago

In 52335:

Twenty Twenty-Two: Sync updates from GitHub.

This commit syncs minor changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], [52222], and [52283]. It reduces the size of a video asset, renames the templates and template parts directories, and adds CSS for button hover states. To view the full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/1a121e0224c75ffa1c34fff4860386e9cdb9e3bd...da994d1fe50c016cd11ecf33da7de33f652184e4.

Props kjellr, mburridge, sabernhardt, hellofromtonya, scruffian.
See #54318.

#33 @prbot
34 hours ago

jffng commented on PR #2017:

Thanks for the quick review @hellofromtonya , closed in https://core.trac.wordpress.org/changeset/52335.

Note: See TracTickets for help on using tickets.