Opened 6 weeks ago
Last modified 34 hours ago
#54318 assigned task (blessed)
Import Twenty Twenty-Two
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | trunk |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
The default theme for 2022 should be added to trunk/wp-content/themes
in time for the feature freeze on November 9.
Change History (33)
This ticket was mentioned in Slack in #core by jffng. View the logs.
6 weeks ago
#2
@
6 weeks ago
- Component changed from Themes to Bundled Theme
- Milestone changed from Awaiting Review to 5.9
- Summary changed from Add the default theme for Twenty Twenty-Two to Import Twenty Twenty-Two
- Type changed from feature request to task (blessed)
This ticket was mentioned in PR #1817 on WordPress/wordpress-develop by jffng.
5 weeks ago
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/54318#ticket
#5
@
4 weeks ago
jffng commented on PR #1817:
In the past discussions and iterations happen on Core merge PRs and are then copied upstream into the theme repository to keep the two in sync. We'll follow the same process here.
Sounds good to me, thank you for the review @desrosj ! I believe the feedback has been addressed, let me know what you think.
#10
@
4 weeks ago
@poena It was not! I probably missed it because there are some rules that ignore asset
directories, and my svn add
command skipped it.
This was fixed in [52107] (I had the incorrect ticket number there), and I rebuilt the nightly. So updating to the latest should fix this.
#11
follow-up:
↓ 12
@
4 weeks ago
With the assets folder included, I am getting the following 404 in the editors and front:
10:01:18.141 localhost/:161 GET http://localhost:8889/wp-content/themes/twentytwentytwo/assets/fonts/SourceSerif4Variable-Roman.ttf.woff2/ net::ERR_ABORTED 404 (Not Found)
#12
in reply to:
↑ 11
@
4 weeks ago
Replying to poena:
With the assets folder included, I am getting the following 404 in the editors and front:
10:01:18.141 localhost/:161 GET http://localhost:8889/wp-content/themes/twentytwentytwo/assets/fonts/SourceSerif4Variable-Roman.ttf.woff2/ net::ERR_ABORTED 404 (Not Found)
I'm not getting a 404 on the font using trunk myself (tested on Safari, Chrome and FF)
This ticket was mentioned in PR #1885 on WordPress/wordpress-develop by jffng.
3 weeks ago
Trac ticket: https://core.trac.wordpress.org/ticket/54318
#16
in reply to:
↑ 13
@
3 weeks ago
Since the theme has been imported in [52081] and [52107], does it make sense to close this and address specific issues in follow up tickets?
Whichever works for you and the team's workflows. Having one ongoing task ticket to use for syncing the theme from GitHub until the RC phase is how it's been done the last few default themes. But whenever the theme is at a solid and stable state (or when you prefer), this can be closed out in favor of specific tickets going forward. It's probably good to archive the GH repo at that time, and move all of the open issues over to Trac.
This ticket was mentioned in PR #1906 on WordPress/wordpress-develop by jffng.
3 weeks ago
Trac ticket: https://core.trac.wordpress.org/ticket/54318
#19
@
3 weeks ago
kjellr commented on PR #1906:
We should be sure to integrate this fix before merge — otherwise the header template errors out:
https://github.com/WordPress/twentytwentytwo/pull/247
This ticket was mentioned in Slack in #core-themes by jffng. View the logs.
2 weeks ago
#22
@
2 weeks ago
desrosj commented on PR #1817:
Committed in https://core.trac.wordpress.org/changeset/52081.
This ticket was mentioned in PR #1970 on WordPress/wordpress-develop by jffng.
9 days ago
Trac ticket: https://core.trac.wordpress.org/ticket/54318
The PR includes the following changes from the Twenty Twenty-One GitHub repo: https://github.com/WordPress/twentytwentytwo/compare/fc07d3974c0a7b41405b7b739dace2fbb3b3605f...1a121e0224c75ffa1c34fff4860386e9cdb9e3bd
#24
@
9 days ago
jffng commented on PR #1906:
Committed in https://core.trac.wordpress.org/changeset/52222
This ticket was mentioned in Slack in #core by jffng. View the logs.
9 days ago
#28
@
8 days ago
jffng commented on PR #1970:
Committed in https://core.trac.wordpress.org/changeset/52283.
#29
@
8 days ago
- Keywords needs-testing has-patch commit removed
Resetting keywords as latest sync updates were committed in [52283].
This ticket was mentioned in PR #2017 on WordPress/wordpress-develop by jffng.
2 days ago
- Keywords has-patch added
Syncs the following changeset for the default theme to trunk
: https://github.com/WordPress/twentytwentytwo/compare/1a121e0224c75ffa1c34fff4860386e9cdb9e3bd...da994d1fe50c016cd11ecf33da7de33f652184e4
Trac ticket: https://core.trac.wordpress.org/ticket/54318
Since 2022 is a block theme, will the checks for Gutenberg need to be removed? [51193]
If so, should we open a separate ticket for that?