Opened 4 months ago
Closed 3 hours ago
#53840 closed defect (bug) (fixed)
Adding or removing items from navigation menus needs audible notification.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Menus | Keywords: | has-patch commit |
Focuses: | accessibility, javascript | Cc: |
Description
The customizer announces that items have been added or removed from navigation as an audible alert for screen readers after the action is performed, but the menu management at Appearance > Menus does not.
Needs wp.a11y.speak notices added to announce those confirmations.
Issue originally noted in #49876, now being broken out to isolate action on this topic.
Attachments (1)
Change History (12)
This ticket was mentioned in PR #1787 on WordPress/wordpress-develop by costdev.
3 weeks ago
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/53840
This ticket was mentioned in Slack in #core-test by costdev. View the logs.
3 weeks ago
This ticket was mentioned in Slack in #core-test by joedolson. View the logs.
13 days ago
This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.
3 days ago
#8
@
3 days ago
- Keywords commit added
Hey @joedolson, the qunit tests now pass. The globals needed to be mocked for the nav tests (whereas they are available when running it live).
I'll mark it for commit
as I thought you said you had already checked that it works as expected (i.e. only the tests passing remained).
#10
@
3 days ago
Minor changes/fixes:
- Changed removal text to 'Item Removed', to match the text of the control that triggers the message.
- Removed duplicate wp.a11y.speak call on item removal (called in eventOnClickMenuItemDelete and in removeMenuItem, but eventOnClickMenuItemDelete calls removeMenuItem, so that creates a duplicate message.)
Hi @joedolson, I see this is
accepted
- Are you working on this solo or is it alright for me to submit a PR for review?