Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix back-compat breaks from Gutenberg 11.9.0 #73

Closed
3 tasks done
iandunn opened this issue Nov 6, 2021 · 2 comments
Closed
3 tasks done

Fix back-compat breaks from Gutenberg 11.9.0 #73

iandunn opened this issue Nov 6, 2021 · 2 comments
Assignees
@iandunn
Labels
[Status] Blocked (external) Blocked by something outside our direct control [Type] Bug Something isn't working
Milestone
State of the Word...

Comments

@iandunn
Copy link
Member

iandunn commented Nov 6, 2021 •
edited
Loading

A lot of nav menu stuff broke when moving from Gutenberg 9a2ae8d183 to c4f180fec9:

Header

Edit: Most of these were fixed by a later Guterberg commit

  • overflow menu spacing messed up on desktop breakpoint
  • overflow menu not aligned on tablet (shows up under Plugins instead of under ...)
  • mobile menu text align centered instead of left
  • mobile menu close icon not visible
  • mobile search modal takes up bottom half of screen instead of full
  • horizontal scrolling on mobile menu

Footer

  • footer menu columns are horizontal instead of vertical
  • footer menu columns not aligned to top

Potential causes

These seem like the most relevant:

There may also be related:
@iandunn iandunn added the [Type] Bug Something isn't working label Nov 6, 2021
@iandunn iandunn added this to the Initial Launch: Functionality milestone Nov 6, 2021
@iandunn
Copy link
Member Author

iandunn commented Nov 8, 2021

git bisect wasn't helpful in identifying the specific commit, because the build tools & npm packages seem to mess it up, and running npm ci && npm run build at each step takes forever.

@iandunn
Copy link
Member Author

iandunn commented Nov 8, 2021

Should probably wait until WordPress/gutenberg#36292 is merged, since that might change this.

@iandunn iandunn added the [Status] Blocked (external) Blocked by something outside our direct control label Nov 8, 2021
@iandunn iandunn self-assigned this Nov 22, 2021
iandunn added a commit to WordPress/wporg-mu-plugins that referenced this issue Nov 23, 2021
@iandunn
Header/Footer: Fix horizontal scrolling in mobile search menu.
e5574c9 
It was broken by Gutenberg 11.9.0.

See WordPress/wporg-news-2021#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iandunn iandunn

Labels
[Status] Blocked (external) Blocked by something outside our direct control [Type] Bug Something isn't working
Projects
None yet
Milestone
State of the Word preview
Development

No branches or pull requests
1 participant
@iandunn