Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine background for local nav & query title banner #67

Closed
1 of 2 tasks
iandunn opened this issue Nov 4, 2021 · 4 comments · Fixed by #90
Closed
1 of 2 tasks

Refine background for local nav & query title banner #67

iandunn opened this issue Nov 4, 2021 · 4 comments · Fixed by #90
Assignees
Labels
[Type] Enhancement New feature or request

Comments

@iandunn
Copy link
Member

iandunn commented Nov 4, 2021

#63 simplified how the local nav bar background/strokes work, so that we don't have to manually create new images for every screen that has a unique color.

It works, but still needs some iteration:

  • When the category list is toggled on, the mask covers the names of some categories, making them hard to read. mask-size: cover is probably to blame, but I couldn't find a way to change that and still get the desired effect when the category list is closed.
  • at some breakpoints, the left/right edges don't look close to the mockup

The solution might be to replace mask-image with a background-image that's the inverse of the current one, like originally discussed in #62 (comment)

It might also be worth considering multiple background images again, but in a way that doesn't require the duplicate images. Like one for the bottom tear, and one for the left/right edge tears. Or maybe combining a background image with a mask image. If 2 images are used, it might help to apply one to nav.local-header and the other to div.local-header__navigation

See #41 for details about the original implementation.

Related: #69, #84

@iandunn iandunn added the [Type] Enhancement New feature or request label Nov 4, 2021
@iandunn iandunn added this to the Initial Launch: Functionality milestone Nov 4, 2021
@iandunn iandunn changed the title Refine local nav background Refine background for local nav & query title banner Nov 5, 2021
@tellyworth
Copy link
Contributor

@kellychoffman and @jeffikus here's another that you might be able to help with.

@MaggieCabrera
Copy link
Collaborator

I'm having a look at this, @tellyworth @iandunn do you think you can add me to the repo so I don't have to fork it?

@iandunn
Copy link
Member Author

iandunn commented Nov 26, 2021

Thanks! You should have access now ✅

@kellychoffman
Copy link
Collaborator

This feels more code than design, but @beafialho and I are available to review any proposed solution(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants