Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Dependabot and sync PRs from notifications #102

Merged
merged 3 commits into from Oct 25, 2021
Merged

Exclude Dependabot and sync PRs from notifications #102

merged 3 commits into from Oct 25, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Oct 25, 2021

Description

This PR makes further improvement to the PRs notifications:

  • turns off notifications for automatd noisy PRs
    • Dependabot makes a large number of PRs every cycle
    • The repo-sync action makes 5 PRs for every change in WordPress/openverse
  • adds a text field to the message which shows up in push notifications

Testing Instructions

  • Make new PRs after this and downstream sync PRs are merged.
  • See fewer messages and more informative push notifications.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from as a code owner Oct 25, 2021
@dhruvkb dhruvkb requested review from zackkrida (assigned from WordPress/openverse-maintainers) and obulat (assigned from WordPress/openverse-maintainers) Oct 25, 2021
@dhruvkb dhruvkb added 🤖 aspect: dx 🧰 goal: internal improvement labels Oct 25, 2021
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Oct 25, 2021
.github/GITHUB.md Show resolved Hide resolved
krysal
krysal approved these changes Oct 25, 2021
.github/workflows/pr_ping.yml Show resolved Hide resolved
Openverse PRs automation moved this from Needs review to Reviewer approved Oct 25, 2021
@zackkrida zackkrida merged commit b27466f into main Oct 25, 2021
2 checks passed
@zackkrida zackkrida deleted the less_pr_ping branch Oct 25, 2021
Openverse PRs automation moved this from Reviewer approved to Merged! Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx 🧰 goal: internal improvement
Projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

4 participants