Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Hide dropdown on single option #314

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

Kevan-Y
Copy link
Contributor

@Kevan-Y Kevan-Y commented Oct 13, 2021

Fixes

Fixes #312 by @sarayourfriend

Description

When there is only one format option, the dropdown addon is not rendered.
image

Testing Instructions

  1. Empty array alt_files of one audio item in src/data/sample-audio-responses.json
  2. Search for that audio
  3. Click to show audio detail page

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Kevan-Y Kevan-Y requested a review from a team as a code owner October 13, 2021 02:35
@Kevan-Y Kevan-Y requested review from AetherUnbound and dhruvkb and removed request for a team October 13, 2021 02:35
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely the simplest solution! Thank you!

src/components/DownloadButton.vue Outdated Show resolved Hide resolved
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! Once we have a proper Button.vue component, I think it'd be better to remove this logic and conditionally render one or the other. For now this is great.

<DropdownButton v-if="formats.length > 1" />
<StandardButton v-else>Download...</StandardButton>

@obulat obulat added 🌟 goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software labels Oct 14, 2021
@obulat obulat merged commit c110127 into WordPress:add/download_button Oct 14, 2021
obulat added a commit that referenced this pull request Oct 16, 2021
* Add download button to the single audio result page

Co-authored-by: Zack Krida <[email protected]>

* Add filetype format display names
* Hide dropdown on single option (#314)
* Potential solution for DownloadButton height (#311)

* Adjust button styles

Apply padding and line-height (leading) to the Dropdown button
Make Full layout's flex row top-aligned
Make PlayPause button not shrinkable

Co-authored-by: Olga Bulat <[email protected]>

Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Kevan Yang <[email protected]>
Co-authored-by: sarayourfriend <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DownloadButton should display no dropdown if there is only one format option
4 participants