Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Logic issues with 'all' and 'image' views #377

Closed
zackkrida opened this issue Oct 27, 2021 · 0 comments · Fixed by #378
Closed

Logic issues with 'all' and 'image' views #377

zackkrida opened this issue Oct 27, 2021 · 0 comments · Fixed by #378
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
Openverse

Comments

@zackkrida
Copy link
Member

There's a few issues in the logic for when to make the 'all' tab active, and when to make the 'image' tab active:

  • In prod, if you go to https://wordpress.org/openverse/search?q=dogs (as opposed to /search/images?q=dogs) no tab is selected. The 'image' tab should be selected instead.
  • In local dev, the homepage search currently routes to /search when audio support is disabled, instead of /search/images like it currently does in prod.
@zackkrida zackkrida added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 27, 2021
@dhruvkb dhruvkb added this to Backlog in Openverse Oct 27, 2021
@zackkrida zackkrida mentioned this issue Oct 27, 2021
Merged
7 tasks
@dhruvkb dhruvkb moved this from Backlog to In progress in Openverse Oct 27, 2021
Openverse automation moved this from In progress to Done! Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
No open projects
Openverse
  
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix logic issues in search type WordPress/openverse-frontend
1 participant
@zackkrida