This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Move scroll button from ImageSearchGrid to the search.vue
page.
#359
Labels
💻 aspect: code
Concerns the software code in the repository
✨ goal: improvement
Improvement to an existing user-facing feature
🟩 priority: low
Low priority and doesn't need to be rushed
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
Projects
Problem
Currently, we only have the scroll button on the ImageSearchGrid, for image search. However, it should be available for all media type search results.
Description
The scroll button should be moved to the
search.vue
page so that it is available on search results for all media types. This will also simplify the Search result components.Alternatives
We could add scroll button to all the supported media type search results components. This way, we might avoid scroll button on non-supported media type pages (eg. video), but we will have to add the ScrollButton component several times.
Additional context
This move will simplify refactoring the Image search result page to use the presentational ImageGrid component instead of the SearchGridManualLoad that is responsible for too many things: images fetching, displaying results metadata, layout of the image grid.
Implementation
The text was updated successfully, but these errors were encountered: