Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Move scroll button from ImageSearchGrid to the search.vue page. #359

Closed
1 task done
obulat opened this issue Oct 26, 2021 · 0 comments · Fixed by #360
Closed
1 task done

Move scroll button from ImageSearchGrid to the search.vue page. #359

obulat opened this issue Oct 26, 2021 · 0 comments · Fixed by #360
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects

Comments

@obulat
Copy link
Contributor

obulat commented Oct 26, 2021

Problem

Currently, we only have the scroll button on the ImageSearchGrid, for image search. However, it should be available for all media type search results.

Description

The scroll button should be moved to the search.vue page so that it is available on search results for all media types. This will also simplify the Search result components.

Alternatives

We could add scroll button to all the supported media type search results components. This way, we might avoid scroll button on non-supported media type pages (eg. video), but we will have to add the ScrollButton component several times.

Additional context

This move will simplify refactoring the Image search result page to use the presentational ImageGrid component instead of the SearchGridManualLoad that is responsible for too many things: images fetching, displaying results metadata, layout of the image grid.

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Oct 26, 2021
@dhruvkb dhruvkb added this to Backlog in Openverse Oct 26, 2021
@dhruvkb dhruvkb moved this from Backlog to In progress in Openverse Oct 26, 2021
Openverse automation moved this from In progress to Done! Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

1 participant