Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

stop tracking of .idea folder or directory #222

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

PuneetDabral
Copy link
Contributor

@PuneetDabral PuneetDabral commented Sep 21, 2021

Fixes

stop tracking of .idea folder or directory #222

Description

stop tracking of .idea folder

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@PuneetDabral PuneetDabral requested a review from a team as a code owner September 21, 2021 07:26
@dhruvkb dhruvkb added this to Needs review in Openverse Sep 21, 2021
@PuneetDabral
Copy link
Contributor Author

sir check this..... now i stop tracking of .idea folder

@PuneetDabral
Copy link
Contributor Author

using this command (git rm -r --cached path_to_your_folder/)

.gitignore Outdated Show resolved Hide resolved
@obulat
Copy link
Contributor

obulat commented Sep 21, 2021

Hi, @PuneetDabral, thank you for your contribution! The removal of dictionaries from the repository works great! 🎉

I have added a small request for change inline. Also, please, add the required PR labels on the right side (we automate the checks for one of the aspect: and one of the goal: labels) and edit the PR message filling in all the relevant items, and removing irrelevant (for example, the Screenshots section).

PuneetDabral added a commit to PuneetDabral/openverse-api that referenced this pull request Sep 21, 2021
@obulat obulat added 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels Sep 21, 2021
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletion of .idea is very nice! The changes to the .gitignore file, although valid, were not necessary.

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@PuneetDabral
Copy link
Contributor Author

can i again pr?

@dhruvkb
Copy link
Member

dhruvkb commented Sep 21, 2021

@PuneetDabral you can update the same PR by pushing (or force pushing) your commits.

@PuneetDabral
Copy link
Contributor Author

ok sir i will update it on 12 pm

@AetherUnbound AetherUnbound linked an issue Sep 21, 2021 that may be closed by this pull request
PuneetDabral added a commit to PuneetDabral/openverse-api that referenced this pull request Sep 21, 2021
@PuneetDabral
Copy link
Contributor Author

PuneetDabral commented Sep 22, 2021

check this sir i was already update this...

@obulat
Copy link
Contributor

obulat commented Sep 22, 2021

check this sir i was already update this...

There is still a change request that needs to be addressed (regarding new lines).

Please also edit the PR message filling in all the relevant items, including the issue that this PR fixes, checking the relevant checklist items, and removing irrelevant sections(for example, the Screenshots section).

@PuneetDabral
Copy link
Contributor Author

so now what i can change ??

@obulat
Copy link
Contributor

obulat commented Sep 22, 2021

so now what i can change ??

Click on 'Edit' in your first message:
PRMessage
And add the missing details. You can see an example of a PR message in #224

Also, address this request: https://github.com/WordPress/openverse-api/pull/222/files#r713258290 . If you do not delete the extra lines, linting will fail, and we will not be able to merge the PR.

@PuneetDabral
Copy link
Contributor Author

PuneetDabral commented Sep 22, 2021

how i fill a check box

@PuneetDabral
Copy link
Contributor Author

now please merge it so i feel motivated ...about my first contribution

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should effectively stop tracking the .idea/ directory.

@dhruvkb dhruvkb requested a review from obulat September 22, 2021 16:09
Openverse automation moved this from Needs review to Reviewer approved Sep 22, 2021
@obulat
Copy link
Contributor

obulat commented Sep 22, 2021

Thank you for your contribution, @PuneetDabral !

@obulat obulat merged commit 4c3f792 into WordPress:main Sep 22, 2021
Openverse automation moved this from Reviewer approved to Done! Sep 22, 2021
@PuneetDabral
Copy link
Contributor Author

thanku very much mam.....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging this pull request may close these issues.

[Bug] Remove .idea/dictionaries
3 participants