Size Change: +584 B (0%)

Total Size: 1.06 MB

_{compressed-size-action}

I guess we can merge this PR.

I would prefer to wait before merging until we have a clear understanding of the approach we're going to take with the navigation components if that's possible

Thanks for the review Marco.

RTL support: on RTL languages, we should swap the direction of the animation
reduced motion: we should disable the animations completely in case the user has expressed a preference for reduced motion

I implemented both of these.

I can spot a horizontal scrollbar while two screens are animating at the same time.

Good catch, it's not really clear how to solve and keep the same animation, adding a "overflow: hidden" could be a solution about I'm worried about side effects (hidden popovers potentially)

convert the Navigator components to TypeScript

😬 I'm not yet familiar with that yet but I can try

focus management: when clicking on a link, the new Screen should receive focus

I implemented a naive version of this. This might require some iterations or input from others.

Actually the typescript conversion here has proven a bit challenging for me, I'd love to see someone else do it (and learn from it) either here or separately.

Thank you for working on the RTL, reduced motion and focus management — they all seem to work well for me and I think they make for a good initial set of a11y improvements. We should probably add a changelog entry to the @wordpress/components package mentioning the introduction of a new experimental set of Navigator components.

I suggest that we merge this PR, and work on a few follow-ups:

• conversion to TypeScript (I am happy to work on it this or next week, and I can tag both @youknowriad and @jorgefilipecosta in the PR so that you can follow along)
• fix the horizontal scrollbar showing while transitioning
• do a more in-depth a11y audit and work on any necessary improvements

What do folks think?

@ciampo This plan makes sense to me.

@ciampo This plan makes sense to me.

Cool, I've updated the tracking issue #34907 with the next steps regarding the Navigator component