Update the global styles sidebar's root view to use Card components #35547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
commented
Oct 12, 2021
| @@ -3,7 +3,6 @@ | |||
| align-items: center; | |||
| justify-content: center; | |||
| min-height: 152px; | |||
| margin: $grid-unit-20; | |||
There was a problem hiding this comment.
It's cool that there's no need for custom spacing like that.
mtias
approved these changes
Oct 12, 2021
youknowriad
commented
Oct 12, 2021
| @@ -16,24 +19,32 @@ import ContextMenu from './context-menu'; | |||
|
|
|||
| function ScreenRoot() { | |||
| return ( | |||
| <> | |||
| <StylesPreview /> | |||
| <Card size="small"> | |||
There was a problem hiding this comment.
To match the spacing in the sidebar header, I had to put "small" as a size for the Card. I wonder if this should be the default (and potentially the only choice).
There was a problem hiding this comment.
Possibly, not sure where else we are using it.
|
Size Change: +23 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small refactoring to the root view in the global styles sidebar. This leverages the Card component to get closer to the in #34574
Maybe there's too match padding between adjacent card bodies but I didn't want to rely on custom CSS.